| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
@benoithudson, could you have a look? |
Sorry, something went wrong.
There was a problem hiding this comment.
Looks great! Glad to see the framework is indeed extensible.
Sorry, something went wrong.
There was a problem hiding this comment.
This is the right style; I don't have an ARM handy to test it on.
I'm assuming you're on some variant of ARM/linux?
Sorry, something went wrong.
|
The only thing I have is an old Raspberry Pi and a few phones, I just used godbolt to get the binaries. That's why I'd like people that had problems to test this branch ;) |
Sorry, something went wrong.
Codecov Report
@@ Coverage Diff @@
## master #887 +/- ##
==========================================
+ Coverage 76.86% 76.94% +0.08%
==========================================
Files 64 64
Lines 5909 5939 +30
Branches 974 974
==========================================
+ Hits 4542 4570 +28
- Misses 1040 1042 +2
Partials 327 327
Continue to review full report at Codecov.
|
Sorry, something went wrong.
Codecov Report
@@ Coverage Diff @@
## master #887 +/- ##
===========================================
- Coverage 76.86% 62.92% -13.95%
===========================================
Files 64 1 -63
Lines 5909 294 -5615
Branches 974 0 -974
===========================================
- Hits 4542 185 -4357
+ Misses 1040 109 -931
+ Partials 327 0 -327
Continue to review full report at Codecov.
|
Sorry, something went wrong.
|
Ummm, I think it seems that it would better if we create a dynamic library and use P/Invoke to get a function address rather than making some hard codes like these? |
Sorry, something went wrong.
|
That would complicate the build process quite a lot though. I'd really like to get to a single arch independent assembly in the future that can just be compiled using dotnet cli without any additional params. |
Sorry, something went wrong.
Sorry, something went wrong.
|
The trick is that it's straight binary, so you only need one of these per cpu arch, not per os (no ELF vs PE distinction, no libc linking etc). Be my guest in providing a reasonable alternative. |
Sorry, something went wrong.
|
Oh, it is. I almost neglect it. |
Sorry, something went wrong.
Me too, which is why my patch that introduced this code was discovering the platform at runtime rather than with ifdefs. If there's some rainy days I'll see about converting more of the code. Eliminating the MONO_LINUX and MONO_OSX defines would be nice; UCS as well. |
Sorry, something went wrong.
|
By the way, the implementation for Runtime.InitializePlatformData just have some limitations. |
Sorry, something went wrong.
|
Probably inline the two functions. IIRC one of the calls has a CPython component, the other I didn't track down. We're getting pretty far off the original topic, I wonder if comments on this PR are the best way to gather our thoughts? |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
What does this implement/fix? Explain your changes.
Adds ARM versions to the native page hack used to survive app-domain reloading.
Does this close any currently open issues?
#873