Repository navigation
Add C# Dictionary to Python Dict conversion - #972
thesn10 wants to merge 3 commits into
Conversation
Sorry, something went wrong.
Codecov Report
@@ Coverage Diff @@
## master #972 +/- ##
=======================================
Coverage 86.71% 86.71%
=======================================
Files 1 1
Lines 301 301
=======================================
Hits 261 261
Misses 40 40
Continue to review full report at Codecov.
|
Sorry, something went wrong.
|
Thanks a lot for this. However, as noted in #963, I'd really like to get away from the implicit conversions and instead allow the wrapped C# object to act like a Python dict without actually performing the conversion (unless explicitly requested). |
Sorry, something went wrong.
|
Oh thats nice :) Will it take long until the implicit conversions get replaced? Because maybe this PR could still be a temporary solution to allow the use of IDictionary as a python dict. In #963 you only mention IEnumerable and ICollection. Will there be a solution for IDictionary too? |
Sorry, something went wrong.
What does this implement/fix? Explain your changes.
You can now convert a C# IDictionary to a Python Dict by calling ToPython()
Dictionary<string, string> dict = new Dictionary<string, string>(); dict.Add("hello", "world"); dynamic d = dict.ToPython(); string value = d.get("hello", "");Does this close any currently open issues?
No, but it is progress for #623
Any other comments?
Do i really have to include a test for this? I mean, the TestConverter.cs file doesnt have any tests for other similar types like IList at all.
Checklist
Check all those that are applicable and complete.