FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

CI for performance tests by lostmsu · Pull Request #992 · pythonnet/pythonnet · GitHub

  1. pythonnet
  2. pythonnet

Repository navigation

CI for performance tests - #992

Merged
filmor merged 25 commits into
pythonnet:masterfrom
losttech:features/PerfTests-CI
Feb 13, 2020
ConversationCommits (25)ChecksFiles changed
Merged

CI for performance tests#992
filmor merged 25 commits into
pythonnet:masterfrom
losttech:features/PerfTests-CI

Conversation

lostmsu commented Nov 21, 2019

Copy link
Copy Markdown
Member

What does this implement/fix? Explain your changes.

Runs performance tests in CI, comparing build with new changes against the latest (2.3 as of now) NuGet release.

Does this close any currently open issues?

#886

Checklist

Nothing applicable.

lostmsu added the WIP label Nov 21, 2019
lostmsu force-pushed the features/PerfTests-CI branch from b357460 to d15d25d Compare November 21, 2019 05:10

codecov-io commented Nov 21, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #992 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #992   +/-   ##
=======================================
  Coverage   86.75%   86.75%           
=======================================
  Files           1        1           
  Lines         302      302           
=======================================
  Hits          262      262           
  Misses         40       40
Flag Coverage Δ
#setup_linux 65.56% <ø> (ø) ⬆️
#setup_windows 71.52% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6c55d4...031e8bb. Read the comment docs.

lostmsu removed the WIP label Nov 21, 2019
lostmsu requested a review from filmor November 21, 2019 17:36

lostmsu commented Nov 21, 2019

Copy link
Copy Markdown
Member Author

@filmor if you are to merge this, I recommend squashing the commit, as there are many intermediate changes, which are insignificant on their own.

lostmsu removed the request for review from filmor November 21, 2019 17:39
lostmsu added the WIP label Nov 21, 2019
filmor reviewed Nov 21, 2019
View reviewed changes
Comment thread src/perf_tests/Python.PerformanceTests.csproj Outdated
lostmsu force-pushed the features/PerfTests-CI branch from af473de to 0eec424 Compare November 21, 2019 20:00
lostmsu removed the WIP label Nov 21, 2019

lostmsu commented Nov 21, 2019

Copy link
Copy Markdown
Member Author

OK, test is passing, and I can see in AppVeyor logs for 3.5 x64 xplat build, that performance is checked.

BTW, 3.5 x64 xplat is the only configuration where perf test runs, as it is the only configuration supported by the published NuGet package.

lostmsu requested a review from filmor November 21, 2019 22:01
lostmsu changed the title WIP: CI for performance tests CI for performance tests Nov 22, 2019

lostmsu commented Nov 23, 2019

Copy link
Copy Markdown
Member Author

I guess this boils down to how much flakiness we can tolerate in perf tests in CI. Letting a bit more wiggle room in the performance goal should make it very unlikely to fail randomly.

lostmsu added 14 commits January 31, 2020 12:33
attempted to add performance tests to CI
c9505df
attempt to fix PerformanceTests xplat CI build
949b55f
enabling building PerformanceTests for Mono
1c92d0c
use Ubuntu 18.04 Bionic Beaver image in Travis CI
4deda8b
fixed AppVeyor path to Python.PerformanceTests.dll
a7b9417
fixed Mono deb sources to bionic
400ea33
slightly relaxed perf target for WriteInt64Property
01ea645
PerformanceTests: explicitly specify platform
419bddf
use framework-specific build of perf tests in xplat and generic other…
f36318f 
…wise
added reference to net461 reference assemblies nuget to perf tests
265b363
added perf tests run to Travis CI
e17f64e
fixed perf tests being build for Any CPU instead of x86
433c016
only run perf tests in Travis on Python 3.5
74ba9d3
added performance tests to the old solution
54f9698
lostmsu force-pushed the features/PerfTests-CI branch from 430ea6e to a6c55d4 Compare January 31, 2020 20:33
filmor merged commit f5548e3 into pythonnet:master Feb 13, 2020
lostmsu mentioned this pull request Feb 20, 2020
Closed
AlexCatarino pushed a commit to QuantConnect/pythonnet that referenced this pull request Jun 27, 2020
CI for performance tests (pythonnet#992)
fffd53a 
* attempted to add performance tests to CI
* attempt to fix PerformanceTests xplat CI build
* enabling building PerformanceTests for Mono
* fixed AppVeyor path to Python.PerformanceTests.dll
* fixed Mono deb sources to bionic
* slightly relaxed perf target for WriteInt64Property
* PerformanceTests: explicitly specify platform
* use framework-specific build of perf tests in xplat and generic otherwise
* added perf tests run to Travis CI
* better error message for a failure to run benchmarks
* appveyor: don't run perf tests in unsupported configurations
* fixed performance test Python version condition in AppVeyor
* explicitly notify when performance tests are skipped in AppVeyor
* relax performance targets to ~10%, improve perf failure message
* switch to the release of Microsoft.NETFramework.ReferenceAssemblies package
filmor mentioned this pull request Feb 14, 2021
Closed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

filmor filmor approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL