FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix geninterop.py to support c_ast.FuncDecl (Python 3.8 tp_print is a function pointer) by Jeff17Robbins · Pull Request #996 · pythonnet/pythonnet · GitHub

Repository navigation

Fix geninterop.py to support c_ast.FuncDecl (Python 3.8 tp_print is a function pointer) - #996

Closed
Jeff17Robbins wants to merge 3 commits into
pythonnet:masterfrom
Jeff17Robbins:master
Closed

Jeff17Robbins wants to merge 3 commits into
pythonnet:masterfrom
Jeff17Robbins:master

Conversation

Copy link
Copy Markdown
Contributor

What does this implement/fix? Explain your changes.

Added conditional support to run geninterop.py on Windows 10. Added support for function pointers (c_ast.FuncDecl) to fix interop38.cs for Python3.8.

Does this close any currently open issues?

close issue #995

Any other comments?

...

Jeff17Robbins changed the title Add files via upload Fix geninterop.py to support c_ast.FuncDecl (Python 3.8 tp_print is a function pointer) Nov 28, 2019

codecov-io commented Nov 28, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #996 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #996   +/-   ##
=======================================
  Coverage   86.71%   86.71%           
=======================================
  Files           1        1           
  Lines         301      301           
=======================================
  Hits          261      261           
  Misses         40       40
Flag Coverage Δ
#setup_linux 65.44% <ø> (ø) ⬆️
#setup_windows 71.42% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f2e2e2...2dc690e. Read the comment docs.

filmor commented Nov 28, 2019

Copy link
Copy Markdown
Member

Great, thanks :)

Could you also regenerate interop38.cs with this?

output from geninterop.py updated to visit function pointers, support running on Windows 10, and 1 minor typo

Copy link
Copy Markdown
Contributor Author

@filmor I'm not experienced at git, so I hope I did this correctly. Happy to learn, so if I made mistakes, please let me know!

filmor commented Nov 28, 2019

Copy link
Copy Markdown
Member

The only non-ideal thing is that you changed the line-endings, the rest is fine :)

I'll see whether I can easily fix this and then we'll merge, thank you very much for your contribution. It would be good if you could add yourself to the AUTHORS.md file as well.

Copy link
Copy Markdown
Contributor Author

I saw that line-ending issue when Github showed me the diff. I definitely felt bad about it, but as a long-time Windows/Microsoft developer (first started on AppleSoft Basic and Microsoft's "The AppleSoft Compiler (TASC)) around 1982, at least I have an excuse.

If you want me to try changing some Visual Code setting and doing it again, happy to do so!

filmor commented Nov 28, 2019

Copy link
Copy Markdown
Member

Merged manually, the whitespace modifications are apparently too much for Github to recognise this. Thanks a lot for the analysis and fix.

filmor closed this Nov 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL