add cdn related functions to python sdk - #244
Merged
jemygraw merged 4 commits intoFeb 3, 2017
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
longbai
reviewed
Feb 3, 2017
Comment thread
qiniu/services/storage/upload_progress_recorder.py
| record_file_name = base64.b64encode(key.encode('utf-8')).decode('utf-8') | ||
| upload_record_file_path = os.path.join(self.record_folder, | ||
| record_file_name) | ||
| record_file_name = hashlib.md5(record_key.encode('utf-8')).hexdigest() |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
做成一个函数
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
其实这里用filename和key做hash并不能保证进度文件唯一，如果往不同的bucket里面传这个同一个文件，filename和key都相同，就会出问题。
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.