fix: skip truncate_datetime for date and timedelta objects - #617
Open
Sanjays2402 wants to merge 1 commit into
Open
fix: skip truncate_datetime for date and timedelta objects#617Sanjays2402 wants to merge 1 commit into
Sanjays2402 wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
DeepDiff(..., truncate_datetime=...) raised TypeError for datetime.date
values ('replace() got an unexpected keyword argument microsecond') and
AttributeError for datetime.timedelta values, because datetime_normalize
applied the truncation unconditionally to every value routed through it.
date has no time components to truncate and timedelta has no replace(),
so the truncation is now applied only to datetime and time objects.
Truncation of datetime/time values is unchanged.
Fixes qlustered#564
Copy link
Copy Markdown
|
⚠️ Please install the Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## master #617 +/- ##
=======================================
Coverage 95.10% 95.10%
=======================================
Files 17 17
Lines 4900 4900
=======================================
Hits 4660 4660
Misses 240 240 ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #564
datetime_normalize applied truncate_datetime to every value routed through it, so DeepDiff(..., truncate_datetime=...) raised TypeError: replace() got an unexpected keyword argument 'microsecond' for datetime.date values and AttributeError for datetime.timedelta values. date has no sub-day components to truncate and timedelta has no replace(), so the truncation is now applied only to datetime and time objects; truncation of those is unchanged.
Regression test added in tests/test_diff_datetime.py: it fails on master with the reported TypeError and passes with the fix.
This change was prepared with AI assistance; the regression test was run locally and fails without the fix.