Add support for version node dependencies in version scripts - #1920
Open
Parth (parth-07) wants to merge 1 commit into
Open
Parth (parth-07) wants to merge 1 commit into
Parth (parth-07) wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Parth (parth-07)
requested review from
quic-areg and
Shankar Easwaran (quic-seaswara)
as code owners
September 21, 2026 14:06
Parth (parth-07)
force-pushed
the
VersionNodeDependency
branch
from
21c50dd to
cae0a4f
Compare
September 21, 2026 14:08
Comment thread
include/eld/Script/VersionScript.h
Comment thread
test/Common/standalone/SymbolVersioning/VersionNodeDependency/VersionNodeDependency.test
Parth (parth-07)
requested review from
Steven Ramirez Rosa (Steven6798) and
Shankar Easwaran (quic-seaswara)
September 23, 2026 15:50
Parth (parth-07)
force-pushed
the
VersionNodeDependency
branch
2 times, most recently
from
e467d85 to
1ce8b65
Compare
September 24, 2026 09:01
quic-areg
reviewed
Oct 2, 2026
quic-areg
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Comment thread
include/eld/Script/VersionScript.h
Parth (parth-07)
force-pushed
the
VersionNodeDependency
branch
from
1ce8b65 to
e403ea4
Compare
October 5, 2026 10:13
Steven Ramirez Rosa (Steven6798)
approved these changes
Oct 5, 2026
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks good. Remember to use proper labeling for the release notes and documentation purposes.
Sorry, something went wrong.
This commit adds real support for GNU version-script node dependencies
instead of warning and discarding them. A dependent node such as
V1 { ... };
V2 { ... } V1;
previously triggered `Dependent nodes are not supported` and the
dependency was silently dropped. Now, a dependency is validated against
already-registered named version nodes when symbol versioning is
enabled, rejecting unknown, forward, and self references the same way
GNU ld does. Symbol scope, version ID assignment, and `.gnu.version`
continue to be driven purely by node order and symbol rules, so this is
metadata-only.
The `.gnu.version_d` writer now emits a dependency as an additional
`Verdaux` entry on the dependent version definition.
Resolves qualcomm#1581
Signed-off-by: Parth Arora <partaror@qti.qualcomm.com>
Parth (parth-07)
force-pushed
the
VersionNodeDependency
branch
from
e403ea4 to
c7c09da
Compare
October 6, 2026 11:29
quic-areg
approved these changes
Oct 6, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds real support for GNU version-script node dependencies instead of warning and discarding them. A dependent node such as
V1 { ... }; V2 { ... } V1;previously triggered Dependent nodes are not supported and the dependency was silently dropped. Now, a dependency is validated against already-registered named version nodes when symbol versioning is enabled, rejecting unknown, forward, and self references the same way GNU ld does. Symbol scope, version ID assignment, and .gnu.version continue to be driven purely by node order and symbol rules, so this is metadata-only.
The .gnu.version_d writer now emits a dependency as an additional Verdaux entry on the dependent version definition.
Resolves #1581