Default linker script rule matching to match-gnu - #1972
Draft
Parth (parth-07) wants to merge 1 commit into
Draft
Parth (parth-07) wants to merge 1 commit into
Parth (parth-07) wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Parth (parth-07)
requested a review
from Shankar Easwaran (quic-seaswara)
as a code owner
September 25, 2026 12:44
Shankar Easwaran (quic-seaswara)
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Let us remove match-llvm/match-gnu both options, and make it as default.
Sorry, something went wrong.
Parth (parth-07)
force-pushed
the
MakeMatchGNUDefault
branch
from
e30dc02 to
c58468d
Compare
September 28, 2026 02:35
Parth (parth-07)
force-pushed
the
MakeMatchGNUDefault
branch
from
c58468d to
cef168e
Compare
September 28, 2026 02:36
Copy link
Copy Markdown
Contributor
Author
Done. I have removed the --script-options command-line option and made match-gnu as the fixed behaviour. |
Sorry, something went wrong.
Parth (parth-07)
force-pushed
the
MakeMatchGNUDefault
branch
from
cef168e to
73b70d7
Compare
September 28, 2026 02:40
Shankar Easwaran (quic-seaswara)
approved these changes
Sep 28, 2026
Copy link
Copy Markdown
Contributor
|
Please include zephyr-check and kernel-check before merging. |
Sorry, something went wrong.
quic-areg
approved these changes
Sep 28, 2026
Parth (parth-07)
force-pushed
the
MakeMatchGNUDefault
branch
from
73b70d7 to
5492ced
Compare
September 29, 2026 08:27
This commit changes the default linker script input section rule-matching behavior to match-gnu, aligning ELD default semantics with GNU ld for archive member matching. Previously, ELD defaulted to match-llvm, which permitted generic file patterns without archive syntax to match enclosing archive names. Additionally, this commit removes match-gnu from the --script-options option, leaving match-llvm as the only valid value when non-GNU matching behavior is explicitly requested. Resolves qualcomm#1049 Signed-off-by: Parth Arora <partaror@qti.qualcomm.com>
Parth (parth-07)
force-pushed
the
MakeMatchGNUDefault
branch
from
5492ced to
f809524
Compare
September 30, 2026 08:00
Parth (parth-07)
marked this pull request as draft
September 30, 2026 13:41
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit changes the default linker script input section rule-matching behavior to match-gnu, aligning ELD default semantics with GNU ld for archive member matching. Previously, ELD defaulted to match-llvm, which permitted generic file patterns without archive syntax to match enclosing archive names.
Additionally, this commit removes match-gnu from the --script-options option, leaving match-llvm as the only valid value when non-GNU matching behavior is explicitly requested.
Resolves #1049