Repository navigation
[reproduce] Preserve linker inputs when reproduce link fails - #2068
Steven Ramirez Rosa (Steven6798) wants to merge 1 commit into
Conversation
Sorry, something went wrong.
| // namespecs that have an explicit mapping entry, preserving normal mapped | ||
| // link behavior. | ||
| if (PConfig.options().hasMappingFile() && !isInternal() && | ||
| (Type != Input::Namespec || PConfig.hasMappingForFile(FileName))) |
There was a problem hiding this comment.
Can this condition be simplified or made into a seperate function ?
Input::resolveReproducePath() ?
This will allow the critical code without reproduce unaffected.
Sorry, something went wrong.
There was a problem hiding this comment.
Sounds good.
Sorry, something went wrong.
There was a problem hiding this comment.
Let me know if my latest change is what you were looking for.
Sorry, something went wrong.
| @@ -1763,6 +1770,8 @@ bool GnuLdDriver::processReproduceOption( | |||
| break; | |||
| } | |||
There was a problem hiding this comment.
I could not follow this.
Sorry, something went wrong.
There was a problem hiding this comment.
We cannot just return because we failed to resolve the action. That's how we end up without the input file in the reproduce.
Sorry, something went wrong.
Capture linker scripts and unresolved namespecs when input activation fails so the reproduce response preserves the original failure. Avoid applying mapping-file resolution to unmapped replay namespecs while retaining normal mapped namespec behavior. Fix: qualcomm#1014 Signed-off-by: Steven Ramirez Rosa <ramirezr@qti.qualcomm.com>
This branch has not been deployed
Reviewers
Requested changes must be addressed to merge this pull request.
Capture linker scripts and unresolved namespecs when input activation fails so the reproduce response preserves the original failure. Avoid applying mapping-file resolution to unmapped replay namespecs while retaining normal mapped namespec behavior.
Fix: #1014