[Relocator] Restore parallelism in scanRelocations - #2074
Open
quic-areg wants to merge 1 commit into
Open
quic-areg wants to merge 1 commit into
quic-areg wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Restores parallel scanRelocations phase in a two-phase approach similar to lld: Phase 1 (scanRelocationParallel) may run concurrently over input files. It only performs the checks that are common to every backend and records which relocations need further processing. It creates no GOT/PLT slots and no dynamic relocations. Phase 2 (replayScanRelocations) is serial and visits the recorded relocations in input order. Slot allocation happens here and retains determinism. Fixes qualcomm#1938 Signed-off-by: quic-areg <aregmi@qti.qualcomm.com>
quic-areg
force-pushed
the
parallel-relocation-scan
branch
from
da204ae to
db2e5c2
Compare
October 6, 2026 14:37
quic-areg
marked this pull request as ready for review
October 6, 2026 14:37
quic-areg
requested review from
Parth (parth-07) and
Shankar Easwaran (quic-seaswara)
as code owners
October 6, 2026 14:37
quic-areg
requested review from
Bhoumik Patidar (BhoumikPatidar) and
Steven Ramirez Rosa (Steven6798)
October 6, 2026 14:37
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
At least 2 approving reviews are required to merge this pull request.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores parallel scanRelocations phase in a two-phase approach similar to lld:
Phase 1 (scanRelocationParallel) may run concurrently over input files. It only performs the checks that are common to every backend and records which relocations need further processing. It creates no GOT/PLT slots and no dynamic relocations.
Phase 2 (replayScanRelocations) is serial and visits the recorded relocations in input order. Slot allocation happens here and retains determinism.
Fixes #1938