FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs(react): update listbox docs demos by 49-22 · Pull Request #349 · qualcomm/qualcomm-ui · GitHub

/ qualcomm-ui Public

docs(react): update listbox docs demos - #349

Open
Nitin (49-22) wants to merge 3 commits into
devfrom
fix/listbox-input-navigation
ConversationCommits (3)ChecksFiles changed
Open

docs(react): update listbox docs demos#349
Nitin (49-22) wants to merge 3 commits into
devfrom
fix/listbox-input-navigation

Conversation

Nitin (49-22) commented Aug 26, 2026 •
edited
Loading

Copy link
Copy Markdown

Summary

  • Updates the React Listbox filtering demo with more region mock data.
  • Adds a scrollable content area to the filtering demo using className="max-h-64 overflow-y-auto".
  • Adds a dynamic data loading demo that keeps Listbox.Content mounted while loading, empty, and loaded states render inside it.

Context

Reviewer feedback clarified that Listbox.Content is expected to always remain mounted, even when no options are available. This PR no longer changes core Listbox keyboard behavior for an initially unmounted content case. Instead, it documents the intended async-data pattern in the React docs.

Testing

pnpm react-docs lint

Ryan Bower (R-Bower) commented Aug 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

The listbox content should always be rendered, even if there are no options available. Also, I was not able to reproduce this bug.

Ryan Bower (R-Bower) commented Aug 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Reopening: Nitin (@49-22) can you post a reproduction? I was unable to reproduce this. If the test reproduction is only possible with Listbox.Content unmounted initially, then this can be closed. Listbox.Content should always be mounted.

Nitin (49-22) commented Aug 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

Yes, it’s reproducible only when Listbox.content is not mounted initially yet

how about keeping an example to ensure even an uninformed AI agent or dev can avoid wasting time in debugging it.

Nitin (49-22) changed the title fix(listbox): support input navigation before content mounts docs(react): update listbox docs demos Aug 27, 2026
Nitin (49-22) force-pushed the fix/listbox-input-navigation branch 2 times, most recently from a7095cb to 928c7f0 Compare August 27, 2026 08:56

Nitin (49-22) commented Aug 27, 2026

Copy link
Copy Markdown
Author

Ryan Bower (@R-Bower) Updated the examples to ensure what I missed is not missed by anyone else.

Nitin (49-22) marked this pull request as ready for review August 28, 2026 08:44
Nitin (49-22) force-pushed the fix/listbox-input-navigation branch from 1744b67 to c6dc02a Compare September 2, 2026 07:04
Nitin (49-22) force-pushed the fix/listbox-input-navigation branch 2 times, most recently from a3e1e56 to 2177488 Compare September 8, 2026 09:09

Nitin (49-22) commented Sep 8, 2026

Copy link
Copy Markdown
Author

Looks like signed commit was missing and DCO check was failing.
Fixed it.
Good to review again.

fix(listbox): support input navigation before content
12e7226 
  mounts

Signed-off-by: Nitin <nitin.nagamalla@gmail.com>
docs(listbox): update React docs demos
9d269ca 
Signed-off-by: Nitin <nitin.nagamalla@gmail.com>
docs(listbox): fix dynamic data example semantics
f4347d3 
Signed-off-by: Nitin <nitin.nagamalla@gmail.com>
Nitin (49-22) force-pushed the fix/listbox-input-navigation branch from 2177488 to f4347d3 Compare September 14, 2026 09:31

Nitin (49-22) commented Sep 14, 2026

Copy link
Copy Markdown
Author

Ryan Bower (@R-Bower) is this good to go or anything pending from my side?

This branch has not been deployed

No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Ryan Bower (R-Bower) Awaiting requested review from R-Bower R-Bower is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL