avoid need for R_NilValue checks in protect code - #285
Merged
romainfrancois merged 8 commits intoMay 17, 2023
Merged
romainfrancois merged 8 commits into
romainfrancois merged 8 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Thanks ! |
Sorry, something went wrong.
romainfrancois
added a commit
that referenced
this pull request
May 24, 2023
This reverts commit dae1b6a.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides a minor optimization, that allows us to avoid the need to check the tail in the precious list for R_NilValue. This is done by ensuring that the "tail" of the precious list is itself initialized as a "cell", and so one can always safely access its CAR.
The only downside is that the "empty" precious list now has two cells rather than one, but it should be worth the bit of extra performance (+ the overall code clarity is IMHO improved).