Update README.md with note on imports - #316
Closed
pepijn-devries wants to merge 1 commit into
Closed
pepijn-devries wants to merge 1 commit into
pepijn-devries wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Thanks for the contribution. I feel that this is a little too specific for a README. Perhaps we can instead do something here to error when the namespace is not found: cpp11/inst/include/cpp11/function.hpp Line 72 in 3c36f7f with a clear error message, and some instructions on how to proceed. |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
Thanks for the response. Yes an error-message will definitely help here. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using functions from other packages using the cpp11 package function, I noticed that when calling such functions R would get stuck and doesn't throw errors or warnings. It took me a while to realise that these functions weren't imported to the namespace. After importing the functions, everything worked smoothly. I've added this note to help others avoid running into the same problem.