Ensure format strings pass check in R-devel/Windows - #345
Merged
DavisVaughan merged 3 commits intoDec 1, 2023
Merged
DavisVaughan merged 3 commits into
DavisVaughan merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
(CI failure seems to be related to differences in snapshot output that doesn't seem to be related to printing the protected list) |
Sorry, something went wrong.
DavisVaughan
force-pushed
the
fix-format-strings
branch
from
e4c1326 to
19b0970
Compare
December 1, 2023 16:45
Copy link
Copy Markdown
Member
|
Thanks! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure exactly why this issue popped up on CI ( apache/arrow#38894 (comment) ), but it seems that at least one format string has %x (which expects an int) where I think the intention was to print memory addresses (i.e., %p). Our CI issue is probably because we're being a tad to aggressive about converting errors to warnings, but it seemed like an easy fix while I was taking a look!