Remove implicit conversion operators on sexp - #390
Open
DavisVaughan wants to merge 2 commits into
Open
DavisVaughan wants to merge 2 commits into
DavisVaughan wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This was referenced Aug 22, 2024
krlmlr
added a commit
to krlmlr/cpp11
that referenced
this pull request
Sep 12, 2026
The merge is textually clean, but its result is not: the three `[[deprecated]]` declarations run to about 135 characters, and `.github/workflows/format.yaml` fails a tree that `clang-format` would reformat. The branch already failed that check before the merge, so this is the merge that fixes it rather than one that broke it. `clang-format` splits each attribute onto its own line and puts the body in braces. Whitespace only: the attributes, their messages and the conversions are unchanged. The feature itself still stands. Upstream's own r-lib#390 would remove these three conversion operators outright rather than deprecate them, which would retire this patch -- but it is blocked on readxl, vroom and supercells, has not moved since August 2024, and no longer merges cleanly. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K8MneV8KqHYUuC8fWV3X5Q
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cpp11 currently allows some somewhat scary implicit conversions between sexp and the 3 types bool, size_t, and double. These are unchecked conversions, and we'd like to remove them. However, doing so breaks readxl, vroom, and supercells, so we sent them PRs for this:
We can merge this once those packages have merged and updated on CRAN