This repository was archived by the owner on May 1, 2026. It is now read-only.
Add the ability to specify RunLoop and RunLoopMode in after and every methods - #38
Open
madeinqc wants to merge 1 commit into
Open
madeinqc wants to merge 1 commit into
madeinqc wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
`every` methods while conserving the initial signature and behavior for backward compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was required in my project to be able to use after and every methods for timers that need to update the UI. The timer needs to run in .commonModes to be able to update the UI while scrolling.
It keep the same behaviour as previously and the signature is backward compatible.
I added a new start function because the splat operator is not available in Swift, hence the need to create a new one that takes an array as parameters.
Feedbacks are welcome, I will adjust the PR accordingly.