FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Swift 4.2 Migration by asowers1 · Pull Request #45 · radex/SwiftyTimer · GitHub

This repository was archived by the owner on May 1, 2026. It is now read-only.
  1. radex
  2. SwiftyTimer

Repository navigation

Swift 4.2 Migration - #45

Merged
asowers1 merged 9 commits into
radex:masterfrom
asowers1:as/Swift4.2
Oct 16, 2018
ConversationCommits (9)ChecksFiles changed
Merged

Swift 4.2 Migration#45
asowers1 merged 9 commits into
radex:masterfrom
asowers1:as/Swift4.2

Conversation

asowers1 commented Oct 9, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

What this does:

  • Updated for Swift 4.2 source compatibility
  • Updated project file to reflect that
  • Project test passing
  • Travis test passing

asowers1 mentioned this pull request Oct 9, 2018
Closed
asowers1 changed the title Building on Swift 4.2 Swift 4.2 Migration Oct 9, 2018

radex commented Oct 14, 2018

Copy link
Copy Markdown
Owner

LGTM @asowers1! Thanks for the PR. Would you mind adding a changelog entry?

PS. I don't really maintain this repo anymore — I can give you GitHub and CocoaPods access if you want to take over

This was referenced Oct 14, 2018
Closed
Closed
Closed

asowers1 commented Oct 14, 2018

Copy link
Copy Markdown
Contributor Author

Sounds good to me! I can take care of that.

asowers1 commented Oct 15, 2018

Copy link
Copy Markdown
Contributor Author

@radex, the changelog is set. I can move ahead with the new tag and pod repo update whenever you're ready.

radex commented Oct 16, 2018

Copy link
Copy Markdown
Owner

@asowers1 Added you as GitHub collaborator and given you access to CocoaPods. Go ahead with pushing the changes. Feel free to update the readme to give yourself credit as the maintainer ;)

asowers1 merged commit 87ef0ed into radex:master Oct 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

asowers1

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL