FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Swift5 & Xcode 10.2 by radianttap · Pull Request #48 · radex/SwiftyTimer · GitHub

This repository was archived by the owner on May 1, 2026. It is now read-only.
  1. radex
  2. SwiftyTimer

Repository navigation

Swift5 & Xcode 10.2 - #48

Open
radianttap wants to merge 9 commits into
radex:masterfrom
radianttap:swift5
ConversationCommits (9)ChecksFiles changed
Open

Swift5 & Xcode 10.2#48
radianttap wants to merge 9 commits into
radex:masterfrom
radianttap:swift5

Conversation

radianttap commented Mar 28, 2019

Copy link
Copy Markdown

Code works on its own, just config stuff

Aleksandar Vacic and others added 4 commits March 27, 2019 13:28

Halenda commented Jul 8, 2019

Copy link
Copy Markdown

I think Travis-CI should be reconfigured to exit without errors, but code looks fine. @radex, can you review this MR?

antoinelamy commented Dec 3, 2019

Copy link
Copy Markdown

@radianttap could you edit the .travis.yml in your PR so it can be merged?

radianttap commented Dec 3, 2019

Copy link
Copy Markdown
Author

I never used Travis thus I have no idea what to edit. I believe owners can edit the PR..?

antoinelamy commented Dec 3, 2019

Copy link
Copy Markdown

@radianttap unfortunately I'm not an owner so I cannot edit the file myself. Basically, you just have to update the value for osx_image in this file:

https://github.com/radex/SwiftyTimer/blob/master/.travis.yml

osx_image: xcode11.2 should do the job.

radianttap commented Dec 3, 2019

Copy link
Copy Markdown
Author

Ok, done.

antoinelamy commented Dec 3, 2019

Copy link
Copy Markdown

Looks like line 20 must be changed as well to update the target operating system:
- xcodebuild -project "$PROJECT" -scheme 'SwiftyTimer' -destination 'name=iPhone 8,OS=12.4' ONLY_ACTIVE_ARCH=NO CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED=NO build | xcpretty

radianttap commented Dec 4, 2019

Copy link
Copy Markdown
Author

Chasing Travis tail, done.

antoinelamy commented Dec 4, 2019

Copy link
Copy Markdown

Thanks! @radex can you review?

radex commented Dec 4, 2019

Copy link
Copy Markdown
Owner

@antoinelamy Sorry, I don't maintain this project anymore — @asowers1 does.

antoinelamy reviewed Dec 4, 2019
View reviewed changes
Comment thread SwiftyTimer.podspec Outdated
s.source = { git: 'https://github.com/radex/SwiftyTimer.git', tag: s.version }
s.swift_version = '4.2'

s.swift_version = '5.0'

antoinelamy Dec 4, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This line should not be required as swift_versions is defined later on and overwrites it.

radianttap Dec 5, 2019

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

At the time when I added that, swift_versions was new so newer CocoaPods was using it while older ones ignored it. I agree, this can now be updated to just one setting, I believe everyone has moved on.

antoinelamy commented Dec 9, 2019

Copy link
Copy Markdown

@asowers1 review please?

NSExceptional commented Jun 16, 2021

Copy link
Copy Markdown

@asowers1 @radex please

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
antoinelamy antoinelamy left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL