FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

perf(base): speed up qqmul and qvmul by petercorke · Pull Request #215 · rai-opensource/spatialmath-python · GitHub

Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension .py  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
37 changes: 30 additions & 7 deletions spatialmath/base/quaternions.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
Expand Up @@ -326,12 +326,19 @@ def qqmul(q1: ArrayLike4, q2: ArrayLike4) -> QuaternionArray:
"""
q1 = smb.getvector(q1, 4)
q2 = smb.getvector(q2, 4)
s1 = q1[0]
v1 = q1[1:4]
s2 = q2[0]
v2 = q2[1:4]
s1, x1, y1, z1 = q1
s2, x2, y2, z2 = q2

return np.r_[s1 * s2 - np.dot(v1, v2), s1 * v2 + s2 * v1 + np.cross(v1, v2)]
# explicit scalar arithmetic avoids the generic-dispatch overhead of
# np.dot/np.cross on a 3-vector, which dominates cost at this size
return np.array(
[
s1 * s2 - x1 * x2 - y1 * y2 - z1 * z2,
s1 * x2 + x1 * s2 + y1 * z2 - z1 * y2,
s1 * y2 - x1 * z2 + y1 * s2 + z1 * x2,
s1 * z2 + x1 * y2 - y1 * x2 + z1 * s2,
]
)


def qinner(q1: ArrayLike4, q2: ArrayLike4) -> float:
Expand Down Expand Up @@ -398,8 +405,24 @@ def qvmul(q: ArrayLike4, v: ArrayLike3) -> R3:
"""
q = smb.getvector(q, 4)
v = smb.getvector(v, 3)
qv = qqmul(q, qqmul(qpure(v), qconj(q)))
return qv[1:4]
s, x, y, z = q
vx, vy, vz = v

# closed-form v' = v + 2s(w x v) + 2 w x (w x v), for q = (s, w) unit;
# mathematically equivalent to q * pure(v) * conj(q) but avoids two full
# Hamilton products (each wasting work on a zero scalar part) and the
# np.cross/np.dot dispatch overhead within them
tx = 2 * (y * vz - z * vy)
ty = 2 * (z * vx - x * vz)
tz = 2 * (x * vy - y * vx)

return np.array(
[
vx + s * tx + (y * tz - z * ty),
vy + s * ty + (z * tx - x * tz),
vz + s * tz + (x * ty - y * tx),
]
)


def vvmul(qa: ArrayLike3, qb: ArrayLike3) -> R3:
Expand Down
Loading

Back | FazBrowse Home | New Git URL