Wrap transport errors as FinTSConnectionError - #215
Merged
raphaelm merged 1 commit intoJun 2, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
raphaelm
approved these changes
Jun 2, 2026
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## master #215 +/- ##
==========================================
- Coverage 87.69% 86.27% -1.43%
==========================================
Files 26 27 +1
Lines 3463 3833 +370
==========================================
+ Hits 3037 3307 +270
- Misses 426 526 +100 ☔ View full report in Codecov by Sentry.
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Network-level failures during dialog initialization currently bubble up as arbitrary exceptions from requests/socket code. FinTSDialog.init catches those broad exceptions and re-raises FinTSDialogInitError with an authentication-focused message, which makes DNS/TLS/TCP failures look like wrong credentials.\n\nThis wraps requests and socket-level failures from FinTSHTTPSConnection.send as FinTSConnectionError. FinTSDialog.init already preserves FinTSConnectionError, so callers can distinguish endpoint/transport failures from authentication failures.\n\nTested with:\n\n uv run --with pytest pytest tests/test_connection.py