fix(repository): validate custom repo URL extension against path only - #1672
Open
Ferdinaelectro1 wants to merge 1 commit into
Open
Ferdinaelectro1 wants to merge 1 commit into
Ferdinaelectro1 wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
isValidRepoUrl() matched the .json/.rpi-imager-manifest extension against the full URL string, so any query string or fragment after the extension broke the match. This rejected valid, authenticated manifest URLs such as Azure Blob SAS links or S3 presigned URLs. Match the extension against QUrl::path() instead, so query parameters and fragments are correctly ignored. Scheme and extension checks are otherwise unchanged. Fixes raspberrypi#1667
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
isValidRepoUrl() requires the URL to end with .json or the manifest
extension, but matches this against the full URL string, including the
query string. This breaks authenticated manifest URLs such as Azure Blob
SAS links or S3 presigned URLs.
Fixes #1667
Fix
Match the extension regex against QUrl::path() instead of the raw URL
string, so query parameters and fragments no longer break the check.
Why keep the extension check
isValidRepoUrl() is used in two places:
deep links (added in 86c3e20)
The deep link can be triggered by an external site without direct user
input, so the extension check acts as a first-pass filter before the
confirmation dialog. This PR keeps that check and only fixes how it's
matched, rather than removing it.