Conversation
Copy link
Copy Markdown
Owner
Sorry, something went wrong.
This was referenced Nov 25, 2017
Open
Comment thread
config/module.config.php
Outdated
| 'ViewPdfStrategy' => __NAMESPACE__ . '\Mvc\Service\ViewPdfStrategyFactory', | ||
| 'Dompdf' => Service\DompdfFactory::class, | ||
| 'ViewPdfRenderer' => Mvc\Service\ViewPdfRendererFactory::class, | ||
| 'ViewPdfStrategy' => Mvc\Service\ViewPdfRendererFactory::class |
Copy link
Copy Markdown
There was a problem hiding this comment.
@raykolbe This should read Mvc\Service\ViewPdfStrategyFactory::class rather than RendererFactory::class.
Sorry, something went wrong.
Copy link
Copy Markdown
Owner
Author
There was a problem hiding this comment.
Good catch.
Sorry, something went wrong.
Copy link
Copy Markdown
|
Any update on this? It would be nice if this was finally usable via composer as 0.6.0. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewerAt least 1 approving review is required to merge this pull request.
Assignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Profile
Description
⚠️ Work in progress: Upgrade to support ZF3.
Notable Breaking Changes
Reason
Ensure continued support of ZF framework.