| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
| renderer = self.get_renderer() | ||
|
|
||
| if not self._needs_draw: | ||
| if not self.figure.stale: |
There was a problem hiding this comment.
[MEDIUM] macOS canvas redraw-gating change has no test coverage
Issue_draw now skips figure.draw whenever figure.stale is false, and draw/draw_idle only call invalidate, but no test in the repository reaches these paths because the suite runs on Agg and never instantiates the macOS canvas. A regression such as the blit pattern (canvas.draw() followed by copy_from_bbox reading an unrendered buffer, since draw() no longer renders synchronously) or a draw_idle() on a non-stale figure no longer forcing a repaint would ship silently.
EvidenceSUSPECTED: the diff adds no tests, and the changed code requires the macOS-only _macosx extension that the Agg-based suite never imports. A macOS-runner or stubbed-canvas test asserting that _draw returns without calling figure.draw when figure.stale is false, and that draw() leaves the renderer unrendered until the event loop runs, would settle it.
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
SWRBench case matplotlib__matplotlib-6283: pinned base 3b2ab9d to head ee192c3 of matplotlib#6283. Benchmark replay, not for merge.