FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

SWR matplotlib__matplotlib-6283 by richeshgupta · Pull Request #131 · razorpaytest/matplotlib · GitHub

Repository navigation

SWR matplotlib__matplotlib-6283 - #131

Open
richeshgupta wants to merge 2 commits into
swr-base-ee192c3from
swr-head-ee192c3
Open

richeshgupta wants to merge 2 commits into
swr-base-ee192c3from
swr-head-ee192c3

Conversation

Copy link
Copy Markdown

SWRBench case matplotlib__matplotlib-6283: pinned base 3b2ab9d to head ee192c3 of matplotlib#6283. Benchmark replay, not for merge.

razorpay-slash Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Automated code review

Reviewed up to ee192c3.
All 5 reviewers completed.

renderer = self.get_renderer()

if not self._needs_draw:
if not self.figure.stale:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

[MEDIUM] macOS canvas redraw-gating change has no test coverage

Issue

_draw now skips figure.draw whenever figure.stale is false, and draw/draw_idle only call invalidate, but no test in the repository reaches these paths because the suite runs on Agg and never instantiates the macOS canvas. A regression such as the blit pattern (canvas.draw() followed by copy_from_bbox reading an unrendered buffer, since draw() no longer renders synchronously) or a draw_idle() on a non-stale figure no longer forcing a repaint would ship silently.

Evidence

SUSPECTED: the diff adds no tests, and the changed code requires the macOS-only _macosx extension that the Agg-based suite never imports. A macOS-runner or stubbed-canvas test asserting that _draw returns without calling figure.draw when figure.stale is false, and that draw() leaves the renderer unrendered until the event loop runs, would settle it.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL