FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

SWR matplotlib__matplotlib-747 by richeshgupta · Pull Request #138 · razorpaytest/matplotlib · GitHub

Repository navigation

SWR matplotlib__matplotlib-747 - #138

Open
richeshgupta wants to merge 4 commits into
swr-base-acfcfdbfrom
swr-head-acfcfdb
Open

richeshgupta wants to merge 4 commits into
swr-base-acfcfdbfrom
swr-head-acfcfdb

Conversation

Copy link
Copy Markdown

SWRBench case matplotlib__matplotlib-747: pinned base 80d1a7c to head acfcfdb of matplotlib#747. Benchmark replay, not for merge.

razorpay-slash Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Automated code review

Reviewed up to acfcfdb.
All 5 reviewers completed.

if alpha != 1.0:
attrib['opacity'] = str(alpha)

attrib['id'] = oid

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

[MEDIUM] New SVG image id emission and gid plumbing are added with no test coverage

Issue

The diff adds id emission for every image element in draw_image, auto-generating ids through RendererSVG._make_id when no gid is set, along with gid pass-through for images and collections. It adds no test that renders an image to SVG, so neither the inline nor the file branch of draw_image is exercised by the suite.

Evidence

SUSPECTED: in lib/matplotlib/tests/test_svg.py, save a figure containing an imshow (plus one with a gid set on the image) to SVG, parse the output, and assert the image element carries the expected id; this fails immediately if the id emission or the gid plumbing regresses.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL