FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

SWR matplotlib__matplotlib-9002 by richeshgupta · Pull Request #150 · razorpaytest/matplotlib · GitHub

Repository navigation

SWR matplotlib__matplotlib-9002 - #150

Open
richeshgupta wants to merge 1 commit into
swr-base-cfff335from
swr-head-cfff335
Open

richeshgupta wants to merge 1 commit into
swr-base-cfff335from
swr-head-cfff335

Conversation

Copy link
Copy Markdown

SWRBench case matplotlib__matplotlib-9002: pinned base f8df71b to head cfff335 of matplotlib#9002. Benchmark replay, not for merge.

Previously, the canvas size would get set to too small because
 - in the FigureCanvasQt.__init__ `get_width_height` is used to set
   the initial size of the canvas
 - `get_width_height` accounts for the dpiratio, but it has not been
   multiplied up yet so it reports half the size it should
 - this get propagated back down into the Figure object in the resize
   method
 - the dpi is then scaled up

This fix
 - moves adding the `_original_dpi` attribute to the Figure as
   soon as possible in the base __init__
 - calls `_update_dpi` before asking the figure how big it is

Closes matplotlib#8717

razorpay-slash Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Automated code review

Reviewed up to cfff335.
All 5 reviewers completed.

✨ No findings.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL