SWR matplotlib__matplotlib-2726 - #152
Open
richeshgupta wants to merge 1 commit into
Open
richeshgupta wants to merge 1 commit into
richeshgupta wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Comment thread
lib/matplotlib/axes.py
| kwargs['antialiaseds'] = False | ||
|
|
||
| collection = mcoll.PolyCollection(verts, **kwargs) | ||
| collection = mcoll.PolyCollection(verts, snap=False, **kwargs) |
Copy link
Copy Markdown
There was a problem hiding this comment.
[MEDIUM] Calling pcolor with a snap keyword argument now raises TypeError
IssueThe explicit snap=False before **kwargs collides with any caller-supplied snap: ax.pcolor(X, Y, C, snap=True) previously forwarded snap to PolyCollection and now raises TypeError: PolyCollection() got multiple values for keyword argument 'snap'.
EvidenceSUSPECTED: A test calling ax.pcolor(x, y, C, snap=True) and expecting a returned collection would settle it; the TypeError is forced by Python whenever kwargs holds 'snap', but earlier code in pcolor may pop it before this line.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SWRBench case matplotlib__matplotlib-2726: pinned base 45f5c45 to head e586c09 of matplotlib#2726. Benchmark replay, not for merge.