FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add a note about vscode-jest by orta · Pull Request #1126 · react/create-react-app · GitHub

/ create-react-app Public

Add a note about vscode-jest - #1126

Merged
gaearon merged 1 commit into
react:masterfrom
orta:vscode-jest
Dec 1, 2016
ConversationCommits (1)ChecksFiles changed
Merged

Add a note about vscode-jest#1126
gaearon merged 1 commit into
react:masterfrom
orta:vscode-jest

Conversation

orta commented Dec 1, 2016

Copy link
Copy Markdown
Contributor

Adds a note about VS Code Jest, didn't try to pitch too hard, given that at this stage of the doc you don't know too much about Jest other than the watcher.

@cpojer your call on the "Similar support for Nuclide is in the works" otherwise I'm happy to remove it.

Screenshot looks like:

cpojer commented Dec 1, 2016

Copy link
Copy Markdown
Contributor

It's not yet being worked on (planned for early next year?) but I don't want to overpromise right now :)

orta commented Dec 1, 2016

Copy link
Copy Markdown
Contributor Author

Cool - removed 👍

gaearon suggested changes Dec 1, 2016
View reviewed changes
Comment thread packages/react-scripts/template/README.md Outdated

gaearon Dec 1, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think it's Visual Studio Code

gaearon Dec 1, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

"with Create React Apps" -> "with Create React App"

gaearon Dec 1, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This provides a lot of IDE-like features while using a text editor.

Can you be a bit more specific?

orta commented Dec 1, 2016

Copy link
Copy Markdown
Contributor Author

Yep - sure, updated 👍

gaearon suggested changes Dec 1, 2016
View reviewed changes
Comment thread packages/react-scripts/template/README.md Outdated

gaearon Dec 1, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nit: Showing -> showing

Comment thread packages/react-scripts/template/README.md Outdated

gaearon Dec 1, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Let's move this to be the last section in Running Tests

orta commented Dec 1, 2016

Copy link
Copy Markdown
Contributor Author

Cool - all changes done 👍

gaearon merged commit 9ce0aa5 into react:master Dec 1, 2016

gaearon commented Dec 1, 2016

Copy link
Copy Markdown
Contributor

Nice, thanks!

alexdriaguine pushed a commit to alexdriaguine/create-react-app that referenced this pull request Jan 23, 2017
Add a note about vscode-jest (react#1126)
ed583fc
randycoulman pushed a commit to CodingZeal/create-react-app that referenced this pull request May 8, 2017
Add a note about vscode-jest (react#1126)
9e2d04f
lock Bot locked and limited conversation to collaborators Jan 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
gaearon gaearon approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed tag: documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL