FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: dependency issue after workbox-webpack-plugin 6.2 release by fguitton · Pull Request #11292 · react/create-react-app · GitHub

fix: dependency issue after workbox-webpack-plugin 6.2 release - #11292

Merged
iansu merged 2 commits into
react:mainfrom
fguitton:fix-deps/workbox-build
Aug 18, 2021
Merged

fix: dependency issue after workbox-webpack-plugin 6.2 release#11292
iansu merged 2 commits into
react:mainfrom
fguitton:fix-deps/workbox-build

Conversation

fguitton commented Aug 6, 2021
edited
Loading

Copy link
Copy Markdown
Contributor

The latest release of workbox-build is not being pulled by react-scripts due to an explicit dependency on workbox-webpack-plugin@6.1.5.

Since there are no breaking changes mentioned in the Workbox releases notes, this PR updated the version to 6.2.0

fguitton changed the title [WIP] Fix sub-dependency issue from workbox-webpack-plugin Fix dependency issue after workbox-webpack-plugin release Aug 6, 2021
fguitton marked this pull request as ready for review August 6, 2021 10:31

Copy link
Copy Markdown
Contributor

Nice! This should be merge soon! cc: @raix

raix linked an issue Aug 6, 2021 that may be closed by this pull request
raix added this to the 5.0 milestone Aug 6, 2021

raix commented Aug 6, 2021

Copy link
Copy Markdown
Contributor

Thanks @fguitton for the pr.
@iansu / @mrmckeb do we need to run yarn compile:lockfile on dependency updates?

fguitton changed the title Fix dependency issue after workbox-webpack-plugin release fix: dependency issue after workbox-webpack-plugin 6.2 release Aug 15, 2021

mrmckeb commented Aug 18, 2021

Copy link
Copy Markdown
Contributor

Sorry @raix, missed that comment - no need, that's a part of the release workflow I think.

iansu merged commit 498c0cf into react:main Aug 18, 2021

iansu commented Aug 18, 2021

Copy link
Copy Markdown
Contributor

Thanks!

fguitton deleted the fix-deps/workbox-build branch August 18, 2021 18:28
EhsanFortuna pushed a commit to EhsanFortuna/create-react-app that referenced this pull request Aug 23, 2021
…#11292)

* fix: Sub-dependency of workbox-webpack-plugin failed to yeild the correct version

* chore: Bump workbox-webpack-plugin to 6.2.4 to address regressions
abhiisheek pushed a commit to abhiisheek/create-react-app that referenced this pull request May 24, 2023
…#11292)

* fix: Sub-dependency of workbox-webpack-plugin failed to yeild the correct version

* chore: Bump workbox-webpack-plugin to 6.2.4 to address regressions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[v5] Workbox webpack plugin current version is broken update to 6.2.0

6 participants


Back | FazBrowse Home | New Git URL