Hi @krreet!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@iansu Due to npm ci added in #11304 , now we have to also commit the package-lock.json . Now the checks should pass.
npm i

npm test

This looks great. Can you revert the changes to packages/create-react-app/yarn.lock.cached though? We only update that file when we do releases. Other than that I think it's ready to merge.

Hi @iansu
Reverted the changes in packages/create-react-app/yarn.lock.cached.
Now this should be ready to merge.

Not sure why we should need to check-in package-lock.json - feels wrong...

@iansu we do sometimes have to run the 'yarn compile:lockfile' for tests to pass