Use "commander" for cli argv handling - #1195
Conversation
Sorry, something went wrong.
|
Could you show the output difference before and after? |
Sorry, something went wrong.
Before:
Usage: create-react-app <project-directory> [--verbose]
create-react-app version: 1.0.0 After:
Usage: index [options] <name>
Options:
-h, --help output usage information
-V, --version output the version number
-v, --verbose to print logs while init
-s, --scripts-version <alternative package> to select a react script variant [react-scripts]
Example of valid script version values:
- a specific npm version: "0.22.0-rc1"
- a .tgz archive from any npm repo: "https://registry.npmjs.org/react-scripts/-/react-scripts-0.20.0.tgz"
- a package prepared with `tasks/clean_pack.sh`: "/Users/home/vjeux/create-react-app/react-scripts-0.22.0.tgz"
1.0.0 |
Sorry, something went wrong.
|
Does the CLI still run on old Node? (It should print an explanation before exiting the process.) |
Sorry, something went wrong.
|
I tried it on a docker running node 0.10.84 and npm 2.15.1. The output was the same. |
Sorry, something went wrong.
Yep. The thinking is that with time, minimal version of react-scripts may increase so we still need to keep check afterwards. It doesn't hurt to check sooner though! |
Sorry, something went wrong.
|
Should we also add a quick check in travis? |
Sorry, something went wrong.
|
It would be nice. |
Sorry, something went wrong.
| if [ `node --version | sed -e 's/^v//' -e 's/\..\+//g'` -lt 4 ] | ||
| then | ||
| cd $temp_app_path | ||
| node "$root_path"/packages/create-react-app/index.js test-node-version && exit 1 || exit 0 |
There was a problem hiding this comment.
We should verify that it prints a nice message instead of failing with e.g. a parse error.
Sorry, something went wrong.
|
I'm a bit concerned the project is abandoned: tj/commander.js#568. |
Sorry, something went wrong.
|
Yarn uses it so should be fine. Thanks! |
Sorry, something went wrong.
* Use "commander" for cli argv handling * Handle different scripts version forms and exits without a name given * Revert comment about min supported node version * Check sooner for the minimal node version * Add travis test for node <4 * Parse stderr in node versions <4
* Use "commander" for cli argv handling * Handle different scripts version forms and exits without a name given * Revert comment about min supported node version * Check sooner for the minimal node version * Add travis test for node <4 * Parse stderr in node versions <4
commander is more easily configurable than the previous tool, and gives some output out-of-the-box.
Also I've bumped the comment on the minimal node version as per #575.