FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

remove webpack double error filtering hack by sidoshi · Pull Request #1755 · react/create-react-app · GitHub

/ create-react-app Public

remove webpack double error filtering hack - #1755

Closed
sidoshi wants to merge 2 commits into
react:masterfrom
sidoshi:master
ConversationCommits (2)ChecksFiles changed
Closed

remove webpack double error filtering hack#1755
sidoshi wants to merge 2 commits into
react:masterfrom
sidoshi:master

Conversation

sidoshi commented Mar 7, 2017

Copy link
Copy Markdown
Contributor

Changes verified by running this commands:

npm run create-react-app test-app
cd test-app
npm start

created a syntax error in App.js.
Error is not duplicated after removing the hack

sidoshi mentioned this pull request Mar 7, 2017
Closed

gaearon commented Mar 7, 2017

Copy link
Copy Markdown
Contributor

Can you check which version of webpack removed the need for the hack? Just to be sure.

gaearon added this to the 0.10.0 milestone Mar 7, 2017

gaearon commented Mar 7, 2017

Copy link
Copy Markdown
Contributor

Note to self or @Timer: this will be a breaking change for react-dev-utils since we remove the workaround and technically people on older webpacks will have worse output.

sidoshi commented Mar 7, 2017

Copy link
Copy Markdown
Contributor Author

v2.1.0-beta.11

gaearon commented Mar 8, 2017

Copy link
Copy Markdown
Contributor

Interestingly, this hack may also be the reason for this disparity:

In this case I actually like the de-duplication and I wish it also happened in the terminal. We should probably investigate this a little bit more.

gaearon mentioned this pull request May 11, 2017
Merged

gaearon commented May 11, 2017

Copy link
Copy Markdown
Contributor

Hey! I'm very sorry—I totally forgot about this PR and removed this part independently in #2113.

My observation in #1755 (comment) kept me from merging this, so I also did #2125 as a followup to avoid this problem.

I appreciate your help with this though!

gaearon closed this May 11, 2017
lock Bot locked and limited conversation to collaborators Jan 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed tag: internal

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL