FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Collapse stack frames that are too close to each other by gaearon · Pull Request #2142 · react/create-react-app · GitHub

Collapse stack frames that are too close to each other - #2142

Closed
gaearon wants to merge 1 commit into
react:masterfrom
gaearon:warning-logic
Closed

Collapse stack frames that are too close to each other#2142
gaearon wants to merge 1 commit into
react:masterfrom
gaearon:warning-logic

Conversation

gaearon commented May 13, 2017

Copy link
Copy Markdown
Contributor

This adjusts warning logic to my latest changes in react/react#9679 (comment).

gaearon changed the title [WIP] Skip extra React stack frames Collapse stack frames that are too close to each other May 14, 2017

gaearon commented May 14, 2017

Copy link
Copy Markdown
Contributor Author

No, this messes up DOM manipulations 😞

gaearon commented May 14, 2017

Copy link
Copy Markdown
Contributor Author

Let's do #2143 instead for now.

gaearon commented May 14, 2017

Copy link
Copy Markdown
Contributor Author

Let's do it as part of #2100.

gaearon closed this May 14, 2017
Timer modified the milestone: 0.10.0 May 15, 2017
lock Bot locked and limited conversation to collaborators Jan 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL