FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Catch "No tests found" during CI by EnoahNetzach · Pull Request #2387 · react/create-react-app · GitHub

/ create-react-app Public

Catch "No tests found" during CI - #2387

Merged
gaearon merged 1 commit into
react:masterfrom
EnoahNetzach:catch-no-tests
May 27, 2017
ConversationCommits (1)ChecksFiles changed
Merged

Catch "No tests found" during CI#2387
gaearon merged 1 commit into
react:masterfrom
EnoahNetzach:catch-no-tests

Conversation

EnoahNetzach commented May 27, 2017

Copy link
Copy Markdown
Contributor

As noted in #2285, appveyor tests are failing.

This PR is intended as a patch to cover this case, while the kitchensink CI tests are fixed.

EnoahNetzach commented May 27, 2017

Copy link
Copy Markdown
Contributor Author

Related to this, I've opened a PR in jest in order to add a CLI arg (--failWithNoTests) to catch errors like this one.

gaearon merged commit 5317b3f into react:master May 27, 2017

gaearon commented May 27, 2017

Copy link
Copy Markdown
Contributor

Thanks!

gaearon added a commit that referenced this pull request May 27, 2017
Revert "Catch "No tests found" during CI (#2387)"
b01dc34 
This reverts commit 5317b3f.
gaearon mentioned this pull request May 27, 2017
Merged
gaearon added a commit that referenced this pull request May 27, 2017
Revert "Catch "No tests found" during CI" (#2390)
3f34238 
* Revert "Fix wrong path expansion in end-to-end test (#2388)"

This reverts commit 2aafaad.

* Revert "Suggest just "yarn build" (#2385)"

This reverts commit 70bf125.

* Revert "Catch "No tests found" during CI (#2387)"

This reverts commit 5317b3f.

EnoahNetzach commented May 28, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@gaearon sorry for not giving an immediate feedback on this, but probably all past appveyor CI "kitchensink" builds skipped the unit tests.

This PR was indeed to see if that could be catched, but I managed to cause a segmentation fault in npm (?!?).
This is consistent with my run on appveyor, so the only things that comes to mind is that either jest's --listTests, or the if [[ ${testsList} =~ "[]" ]]; then syntax causes it on windows.

Fact is, we have still no unit test coverage on windows 😞..

EnoahNetzach commented May 28, 2017

Copy link
Copy Markdown
Contributor Author

...aaand it seems like you figured it out 😛

gaearon commented May 28, 2017

Copy link
Copy Markdown
Contributor

Yea, I just reverted for now 😄

zangrafx added a commit to zangrafx/create-react-app that referenced this pull request May 31, 2017
Merge branch 'master' into zangrafx
5411717 
* master:
  Add WebStorm >2017 launchEditor Support (react#2414)
  docs: update `jest-enzyme` section (react#2392)
  Fix detection of parent directory in ModuleScopePlugin (react#2405)
  Added cache clear to e2e scripts (react#2400)
  Fix kill command in e2e-kitchensink.sh cleanup (react#2397)
  Revert "Catch "No tests found" during CI" (react#2390)
  Fix wrong path expansion in end-to-end test (react#2388)
  Suggest just "yarn build" (react#2385)
  Catch "No tests found" during CI (react#2387)
  Publish
  Add changelog for 1.0.7 (react#2384)
  Update webpack to 2.6.1 (react#2383)
  Consistently set environment variables (react#2382)
  Disable comparisons feature in uglify compression in production (react#2379)
  Removed the overriding of reduce_vars to false since webpack v2.6.0 included the fixed for Uglify bug (react#2351)
gaearon mentioned this pull request Jun 28, 2017
Merged
romaindso pushed a commit to romaindso/create-react-app that referenced this pull request Jul 10, 2017
Catch "No tests found" during CI (react#2387)
bc1a01f
romaindso pushed a commit to romaindso/create-react-app that referenced this pull request Jul 10, 2017
Revert "Catch "No tests found" during CI" (react#2390)
8bb7441 
* Revert "Fix wrong path expansion in end-to-end test (react#2388)"

This reverts commit 2aafaad.

* Revert "Suggest just "yarn build" (react#2385)"

This reverts commit 70bf125.

* Revert "Catch "No tests found" during CI (react#2387)"

This reverts commit 5317b3f.
wmonk referenced this pull request in wmonk/create-react-app-typescript Aug 7, 2017
Catch "No tests found" during CI (#2387)
78886fd
wmonk referenced this pull request in wmonk/create-react-app-typescript Aug 7, 2017
Revert "Catch "No tests found" during CI" (#2390)
55c2cc6 
* Revert "Fix wrong path expansion in end-to-end test (#2388)"

This reverts commit 2aafaad.

* Revert "Suggest just "yarn build" (#2385)"

This reverts commit 70bf125.

* Revert "Catch "No tests found" during CI (#2387)"

This reverts commit 5317b3f.
lock Bot locked and limited conversation to collaborators Jan 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed tag: internal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL