Test Node 8 on Travis - #2659
Merged
gaearon merged 11 commits intoJun 28, 2017
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
We still test Node 7 on AppVeyor
Copy link
Copy Markdown
Contributor
Author
|
Um, this doesn't look amazing 😞 > fsevents@1.1.2 install /tmp/tmp.nEJmaLIQL1/test-app/node_modules/fsevents > node install npm ERR! Cannot read property 'type' of undefined |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Seems like this error is npm@5.0.3 bug npm/npm#16812. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Heh. Seems like no chance to run with npm@5: > @ build C:\projects\create-react-app-a3khu
> node packages/react-scripts/scripts/build.js
module.js:472
throw err;
^
Error: Cannot find module 'html-webpack-plugin'
at Function.Module._resolveFilename (module.js:470:15)
at Function.Module._load (module.js:418:25)
at Module.require (module.js:498:17)
at require (internal/module.js:20:19)
at Object.<anonymous> (C:\projects\create-react-app-a3khu\packages\react-scripts\config\webpack.config.prod.js:16:27)
at Module._compile (module.js:571:32)
at Object.Module._extensions..js (module.js:580:10)
at Module.load (module.js:488:32)
at tryModuleLoad (module.js:447:12)
at Function.Module._load (module.js:439:3)
npm ERR! Windows_NT 10.0.14393
I'll try to pin it at 4.x so that we can at least test Node 8 alone. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Was there a specific reason we don't test Node 8 on AppVeyor? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
I don't want to make CI time slower. So I'd rather test two versions here and two versions there. This doesn't catch everything but that's the tradeoff. |
Sorry, something went wrong.
zangrafx
added a commit
to absolvent/create-react-app
that referenced
this pull request
Jun 29, 2017
* upstream/master: (55 commits) Fix minor typo (react#2679) Bootstrap with Yarn when available (react#2673) Add more info about apache client side routing (react#2666) Test Node 8 on Travis (react#2659) Add json and css to lint-staged in template README (react#2671) Add a note about fixed vulnerability in 1.0.8 Publish Changelog for 1.0.8 (react#2664) Reformat source code with Prettier 1.5.2 Update Prettier to v1 (react#2465) Update ISSUE_TEMPLATE.md Local testing docker links (react#2662) Better React Native Web support (react#2511) Bump dependencies (react#2658) Minor code style edits to user guide (react#2660) Don't ask to install webpack for using Styleguidist (react#2656) Put react-scripts in dependencies, not devDependencies (react#2657) Razzle added to the alternatives (react#2517) Warn about large bundle sizes (react#2648) Add instructions to use source-map-explorer (react#1641) ... # Conflicts: # packages/react-dev-utils/package.json # packages/react-scripts/config/webpack.config.dev.js # packages/react-scripts/config/webpack.config.prod.js # packages/react-scripts/package.json
Merged
romaindso
pushed a commit
to romaindso/create-react-app
that referenced
this pull request
Jul 10, 2017
* Test Node 8 on Travis We still test Node 7 on AppVeyor * Update e2e-installs.sh * Update e2e-kitchensink.sh * Update e2e-simple.sh * Update e2e-installs.sh * Update e2e-kitchensink.sh * Update e2e-installs.sh * Update e2e-simple.sh * Update e2e-simple.sh * Update e2e-kitchensink.sh * Update e2e-installs.sh
wmonk
referenced
this pull request
in wmonk/create-react-app-typescript
Aug 7, 2017
* Test Node 8 on Travis We still test Node 7 on AppVeyor * Update e2e-installs.sh * Update e2e-kitchensink.sh * Update e2e-simple.sh * Update e2e-installs.sh * Update e2e-kitchensink.sh * Update e2e-installs.sh * Update e2e-simple.sh * Update e2e-simple.sh * Update e2e-kitchensink.sh * Update e2e-installs.sh
morgs32
pushed a commit
to BrickworkSoftware/create-react-app
that referenced
this pull request
Sep 1, 2017
* Test Node 8 on Travis We still test Node 7 on AppVeyor * Update e2e-installs.sh * Update e2e-kitchensink.sh * Update e2e-simple.sh * Update e2e-installs.sh * Update e2e-kitchensink.sh * Update e2e-installs.sh * Update e2e-simple.sh * Update e2e-simple.sh * Update e2e-kitchensink.sh * Update e2e-installs.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We still test Node 7 on AppVeyor