add experimental babel-plugin-macros support - #3675
Merged
gaearon merged 2 commits intoJan 9, 2018
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
closes react#2730 This will remain undocumented until the brave have tried it in the wild. **Test Plan:** There's currently no established way to test changes to `babel-preset-react-app`. But I did create [`unmaintained-react-scripts-babel-macros`](https://www.npmjs.com/package/unmaintained-react-scripts-babel-macros) [a while back](react#2730 (comment)) and it worked well.
Copy link
Copy Markdown
Contributor
Author
|
Copied from the linked issue: Ok, so, check this out: unmaintained-react-scripts-babel-macros diff:
(this would be implemented as part of babel-preset-react-app if it becomes official) App.js
npm test
npm start
So that's pretty rock solid awesome... 😄 Note: that was before the babel-macros -> babel-plugin-macros name change which I did to improve the compatibility with babel 7. There have been no breaking changes other than the name change since I created unmaintained-react-scripts-babel-macros 👍 |
Sorry, something went wrong.
This was referenced Jan 2, 2018
Copy link
Copy Markdown
|
I understand that it is a massive change but any chance this could land "unsupported" without having to wait for 2.0? Landing it would allow a lot of people to test this actually out in the wild and promote adding macros support to various babel plugins. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Merged into next. |
Sorry, something went wrong.
gaearon
pushed a commit
that referenced
this pull request
Jan 9, 2018
* add experimental babel-plugin-macros support closes #2730 This will remain undocumented until the brave have tried it in the wild. **Test Plan:** There's currently no established way to test changes to `babel-preset-react-app`. But I did create [`unmaintained-react-scripts-babel-macros`](https://www.npmjs.com/package/unmaintained-react-scripts-babel-macros) [a while back](#2730 (comment)) and it worked well. * Pin the version
gaearon
pushed a commit
that referenced
this pull request
Jan 10, 2018
* add experimental babel-plugin-macros support closes #2730 This will remain undocumented until the brave have tried it in the wild. **Test Plan:** There's currently no established way to test changes to `babel-preset-react-app`. But I did create [`unmaintained-react-scripts-babel-macros`](https://www.npmjs.com/package/unmaintained-react-scripts-babel-macros) [a while back](#2730 (comment)) and it worked well. * Pin the version
Timer
pushed a commit
to Timer/create-react-app
that referenced
this pull request
Jan 11, 2018
* add experimental babel-plugin-macros support closes react#2730 This will remain undocumented until the brave have tried it in the wild. **Test Plan:** There's currently no established way to test changes to `babel-preset-react-app`. But I did create [`unmaintained-react-scripts-babel-macros`](https://www.npmjs.com/package/unmaintained-react-scripts-babel-macros) [a while back](react#2730 (comment)) and it worked well. * Pin the version
Timer
pushed a commit
that referenced
this pull request
Jan 11, 2018
* add experimental babel-plugin-macros support closes #2730 This will remain undocumented until the brave have tried it in the wild. **Test Plan:** There's currently no established way to test changes to `babel-preset-react-app`. But I did create [`unmaintained-react-scripts-babel-macros`](https://www.npmjs.com/package/unmaintained-react-scripts-babel-macros) [a while back](#2730 (comment)) and it worked well. * Pin the version
Timer
pushed a commit
to Timer/create-react-app
that referenced
this pull request
Jan 11, 2018
* add experimental babel-plugin-macros support closes react#2730 This will remain undocumented until the brave have tried it in the wild. **Test Plan:** There's currently no established way to test changes to `babel-preset-react-app`. But I did create [`unmaintained-react-scripts-babel-macros`](https://www.npmjs.com/package/unmaintained-react-scripts-babel-macros) [a while back](react#2730 (comment)) and it worked well. * Pin the version
Timer
pushed a commit
to Timer/create-react-app
that referenced
this pull request
Jan 13, 2018
* add experimental babel-plugin-macros support closes react#2730 This will remain undocumented until the brave have tried it in the wild. **Test Plan:** There's currently no established way to test changes to `babel-preset-react-app`. But I did create [`unmaintained-react-scripts-babel-macros`](https://www.npmjs.com/package/unmaintained-react-scripts-babel-macros) [a while back](react#2730 (comment)) and it worked well. * Pin the version
gaearon
pushed a commit
that referenced
this pull request
Jan 13, 2018
* add experimental babel-plugin-macros support closes #2730 This will remain undocumented until the brave have tried it in the wild. **Test Plan:** There's currently no established way to test changes to `babel-preset-react-app`. But I did create [`unmaintained-react-scripts-babel-macros`](https://www.npmjs.com/package/unmaintained-react-scripts-babel-macros) [a while back](#2730 (comment)) and it worked well. * Pin the version
Timer
pushed a commit
that referenced
this pull request
Jan 14, 2018
* add experimental babel-plugin-macros support closes #2730 This will remain undocumented until the brave have tried it in the wild. **Test Plan:** There's currently no established way to test changes to `babel-preset-react-app`. But I did create [`unmaintained-react-scripts-babel-macros`](https://www.npmjs.com/package/unmaintained-react-scripts-babel-macros) [a while back](#2730 (comment)) and it worked well. * Pin the version
gaearon
pushed a commit
that referenced
this pull request
Jan 14, 2018
* add experimental babel-plugin-macros support closes #2730 This will remain undocumented until the brave have tried it in the wild. **Test Plan:** There's currently no established way to test changes to `babel-preset-react-app`. But I did create [`unmaintained-react-scripts-babel-macros`](https://www.npmjs.com/package/unmaintained-react-scripts-babel-macros) [a while back](#2730 (comment)) and it worked well. * Pin the version
gaearon
pushed a commit
that referenced
this pull request
Jan 14, 2018
* add experimental babel-plugin-macros support closes #2730 This will remain undocumented until the brave have tried it in the wild. **Test Plan:** There's currently no established way to test changes to `babel-preset-react-app`. But I did create [`unmaintained-react-scripts-babel-macros`](https://www.npmjs.com/package/unmaintained-react-scripts-babel-macros) [a while back](#2730 (comment)) and it worked well. * Pin the version
gaearon
pushed a commit
that referenced
this pull request
Jan 14, 2018
* add experimental babel-plugin-macros support closes #2730 This will remain undocumented until the brave have tried it in the wild. **Test Plan:** There's currently no established way to test changes to `babel-preset-react-app`. But I did create [`unmaintained-react-scripts-babel-macros`](https://www.npmjs.com/package/unmaintained-react-scripts-babel-macros) [a while back](#2730 (comment)) and it worked well. * Pin the version
gaearon
pushed a commit
that referenced
this pull request
Jan 14, 2018
* add experimental babel-plugin-macros support closes #2730 This will remain undocumented until the brave have tried it in the wild. **Test Plan:** There's currently no established way to test changes to `babel-preset-react-app`. But I did create [`unmaintained-react-scripts-babel-macros`](https://www.npmjs.com/package/unmaintained-react-scripts-babel-macros) [a while back](#2730 (comment)) and it worked well. * Pin the version
Timer
pushed a commit
to Timer/create-react-app
that referenced
this pull request
Jan 15, 2018
* add experimental babel-plugin-macros support closes react#2730 This will remain undocumented until the brave have tried it in the wild. **Test Plan:** There's currently no established way to test changes to `babel-preset-react-app`. But I did create [`unmaintained-react-scripts-babel-macros`](https://www.npmjs.com/package/unmaintained-react-scripts-babel-macros) [a while back](react#2730 (comment)) and it worked well. * Pin the version
Copy link
Copy Markdown
Contributor
|
Support for this has been released in the first v2 alpha version. See #3815 for more details! |
Sorry, something went wrong.
Closed
Open
akstuhl
pushed a commit
to akstuhl/create-react-app
that referenced
this pull request
Mar 15, 2018
* add experimental babel-plugin-macros support closes react#2730 This will remain undocumented until the brave have tried it in the wild. **Test Plan:** There's currently no established way to test changes to `babel-preset-react-app`. But I did create [`unmaintained-react-scripts-babel-macros`](https://www.npmjs.com/package/unmaintained-react-scripts-babel-macros) [a while back](react#2730 (comment)) and it worked well. * Pin the version
Copy link
Copy Markdown
Contributor
|
It shipped in 2.0. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
This is just awesome! 🎉 |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Do you have to eject to make it work? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
You're probably trying to use an outdated macro. What are you trying to use? |
Sorry, something went wrong.
Copy link
Copy Markdown
|
I'm trying to use https://github.com/leoasis/graphql-tag.macro |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Yeah, that needs to be updated to babel-plugin-macros: https://github.com/leoasis/graphql-tag.macro/blob/47919df7548bd698076cb74fa777874a49bc9bbe/package.json#L20 Luckily the upgrade is pretty simple. Pretty much find/replace babel-macros for babel-plugin-macros. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
ok thanks! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2730
This will remain undocumented until the brave have tried it in the wild.
Test Plan:
There's currently no established way to test changes to
babel-preset-react-app. But I did create unmaintained-react-scripts-babel-macros a while back and it worked well.