FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Preserve quotes in font values during minification by veltman · Pull Request #4122 · react/create-react-app · GitHub

/ create-react-app Public

Preserve quotes in font values during minification - #4122

Closed
veltman wants to merge 1 commit into
react:masterfrom
veltman:next
ConversationCommits (1)ChecksFiles changed
Closed

Preserve quotes in font values during minification#4122
veltman wants to merge 1 commit into
react:masterfrom
veltman:next

Conversation

veltman commented Mar 7, 2018

Copy link
Copy Markdown

Closes #4121.

facebook-github-bot commented Mar 7, 2018

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented Mar 7, 2018

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Timer added this to the 2.0.0 milestone Mar 8, 2018

Timer commented Mar 8, 2018

Copy link
Copy Markdown
Contributor

@veltman just letting you know I'm going to sit on this for a while before merging as we figure out a final patch release for 1.x.

iansu commented Mar 8, 2018

Copy link
Copy Markdown
Contributor

Should we update this PR to target master instead of next then?

Timer closed this Sep 26, 2018
Timer reopened this Sep 26, 2018
Timer modified the milestones: 2.0.x, 2.x Sep 26, 2018
gaearon closed this Nov 1, 2018
Timer changed the base branch from next to master January 8, 2019 00:38
Timer modified the milestones: 2.x, 2.1.x Jan 8, 2019
Timer reopened this Jan 8, 2019
Timer modified the milestones: 2.1.x, 2.1.4 Jan 8, 2019
ianschmitz modified the milestones: 2.1.4, 2.1.5 Feb 10, 2019
iansu modified the milestones: 2.1.6, 2.1.x, 3.x Mar 6, 2019

heyimalex commented Dec 13, 2019

Copy link
Copy Markdown
Contributor

Should be closed by #8106?

heyimalex closed this Dec 13, 2019
lock Bot locked and limited conversation to collaborators Dec 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
pmourao pmourao approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed tag: bug fix

Projects

None yet

Milestone

5.x

Development

Successfully merging this pull request may close these issues.

Prod config produces invalid font-family values in minified CSS

8 participants

Back | FazBrowse Home | New Git URL