| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
I'm not sure if this is the best way to handle this. If we do this then we have to remember to not update this dependency in the future. Is there a lightweight alternative to Inquirer that we could use instead? |
Sorry, something went wrong.
|
Yep, there definitely should be, will check later. I think you added the inquirer library over prompt.js #1772 |
Sorry, something went wrong.
|
That's right. I think that was my first contribution to Create React App. 😀 I'd like to avoid going back to a custom solution. There was a reason we moved away from that in the first place. I'll look around a bit too and see if I can find a good alternative. I suppose we could also raise an issue with Inquirer if someone hasn't already. |
Sorry, something went wrong.
|
closing this in favor of a smaller package. |
Sorry, something went wrong.
|
@iansu finally found something reasonable: |
Sorry, something went wrong.
|
Asking inquirer to use a different Observable implementation is probably a better bet. eslint@5 is using newer versions of inquirer, so it'll come back, anyway. |
Sorry, something went wrong.
|
hmmm. they upgraded from rx-lite (400kb) to rx5 and more recently rx6. |
Sorry, something went wrong.
|
@bugzpodder Do you mind opening an issue with Inquirer about reducing their install size? Let's see what they say before we consider replacing the package. |
Sorry, something went wrong.
|
Sure I'll see if i can open a few issues. |
Sorry, something went wrong.
|
It looks like RxJS is intentionally publishing src. Let's see if we can get this fixed upstream and if not then we can discuss replacing Inquirer. |
Sorry, something went wrong.
|
The src is about 2.2MB, so its unclear if excluding source will help that much. 1.7M ./operators 384K ./util 188K ./scheduler 36K ./symbol 96K ./testing 4.0M ./_esm5 1.5M ./add 3.9M ./_esm2015 924K ./observable 1.2M ./operator 2.4M ./bundles 2.2M ./src 19M . |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
#3880 (comment)
Basically removes rxjs dependency, which is around 18MB.
Tested yarn eject, yes/no.