FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Document what npm build does and pushState by ldct · Pull Request #933 · react/create-react-app · GitHub

/ create-react-app Public

Document what npm build does and pushState - #933

Merged
gaearon merged 4 commits into
react:masterfrom
ldct:master
Dec 5, 2016
ConversationCommits (4)ChecksFiles changed
Merged

Document what npm build does and pushState#933
gaearon merged 4 commits into
react:masterfrom
ldct:master

Conversation

ldct commented Oct 19, 2016

Copy link
Copy Markdown
Contributor

The User Guide does not actually document what npm run build does. The docs also don't describe how exactly to "deploy" the resulting build directory.

This PR describes what npm run build does and what it means to deploy the build in the Users Guide.

Additionally, it describes the pushState gotcha which was previously only described in reference to specific servers (eg github pages).

facebook-github-bot commented Oct 19, 2016

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

facebook-github-bot commented Oct 19, 2016

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

gaearon reviewed Oct 28, 2016
View reviewed changes
Comment thread packages/react-scripts/template/README.md Outdated

gaearon Oct 28, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please uppercase HTTP.

requests [...] are served

ldct Oct 30, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

fixed

Comment thread packages/react-scripts/template/README.md Outdated

gaearon Oct 28, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This jumps to an example too abruptly. Maybe mention "For example, you can serve static files with Python:"?
And then maybe add an Express example.

ldct Oct 30, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

fixed

Comment thread packages/react-scripts/template/README.md Outdated

gaearon Oct 28, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This describes the problem but doesn't describe the solution.

ldct Oct 30, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I believe this describes the solution

The server needs to be configured to respond to a request to /todos/42 by serving index.html.

The way to configure the server to do so depends on the server used; there's some server-specific information, eg in the Github Pages section.

gaearon merged commit b61dc67 into react:master Dec 5, 2016

gaearon commented Dec 5, 2016

Copy link
Copy Markdown
Contributor

Slightly tweaked and merged. Thank you so much!

mofelee added a commit to xiaohu-developer/create-react-app that referenced this pull request Dec 7, 2016
Merge branch 'master' into sparta-webapp
f8c88af 
* master: (30 commits)
  Relax peerDependencies for ESLint preset (react#1191)
  Update Webpack to fix source map issues (react#1188)
  Update webpack prod config (react#1181)
  Chrome 'open tab' reuse an empty tab when possible (react#1165)
  Use file-loader for svgs (react#1180)
  Fix Babel issues in tests by applying the right transforms (react#1179)
  [babel-preset-react-app] Temporary fix missing babel plugins (react#1177)
  Add Subresource Integrity support (react#1176)
  Remove path module from webpack config on eject. (react#1175)
  Don't strip stack traces of evaluated webpack bundles (react#1050)
  Add deploy to Firebase CDN on template's README (Closes react#374) (react#1143)
  Update e2e.sh (react#1167)
  Document what npm build does and pushState (react#933)
  Fix minor typo/grammar (react#1099)
  Add "npm run build silently fails" to Troubleshooting (react#1168)
  Add testURL to jest config (react#1120)
  Make jsx-no-undef rule an error (react#1159)
  Update CHANGELOG.md
  Publish
  Update changelog for 0.8.1
  ...
alexdriaguine pushed a commit to alexdriaguine/create-react-app that referenced this pull request Jan 23, 2017
Document what npm build does and pushState (react#933)
394e834 
* Document what npm build does and pushState

* Fix typos, add express example

* Tweaks

* Update README.md
randycoulman pushed a commit to CodingZeal/create-react-app that referenced this pull request May 8, 2017
Document what npm build does and pushState (react#933)
9c60498 
* Document what npm build does and pushState

* Fix typos, add express example

* Tweaks

* Update README.md
lock Bot locked and limited conversation to collaborators Jan 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
gaearon gaearon left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL