FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: Use TUnit for the unit test, cleanup state by glennawatson · Pull Request #1459 · reactiveui/splat · GitHub

chore: Use TUnit for the unit test, cleanup state - #1459

Merged
glennawatson merged 2 commits into
mainfrom
glennawatson/convert-tunit
Dec 30, 2025
Merged

chore: Use TUnit for the unit test, cleanup state#1459
glennawatson merged 2 commits into
mainfrom
glennawatson/convert-tunit

Conversation

Copy link
Copy Markdown
Contributor
  • Convert NUnit to TUnit
  • Add scoped state helpers to remove state.

Documentation Modernization and Project Refocus:

  • The CLAUDE.md documentation is updated to describe Splat as the core library instead of ReactiveUI, including a detailed architecture overview, key patterns, and philosophy. All build, test, and configuration instructions now reference Splat projects and solution files, and the documentation emphasizes zero-reflection and source generator approaches for AOT compatibility. [1] [2] [3] [4] [5]

Build and Test System Updates:

  • All build and test commands are updated to use the new Splat.slnx solution format and Splat test projects, replacing legacy ReactiveUI references. The documentation now highlights the use of SLNX (XML-based solution format) and outlines OS-aware build strategies. [1] [2]
  • .claude/settings.local.json is removed, cleaning up unused local configuration.

AOT Compatibility and Code Quality Improvements:

  • Documentation now strongly prioritizes zero-reflection solutions, source generators, and explicit service registration for AOT compatibility, with concrete examples and references to source generator packages. [1] [2] [3]
  • The code style and testing guidelines are updated to require parallel test execution, enforce XML documentation, and clarify naming conventions for test projects. [1] [2]

Test Project Configuration Simplification:

  • The src/Directory.Build.props file is simplified: legacy NUnit runner and analyzer references are removed, test projects now use TUnit and Verify.TUnit, and warning suppression is streamlined. [1] [2]

General Cleanup and Consistency:

  • References to legacy files and naming conventions are updated throughout documentation and build files for consistency with the new Splat-centric structure. [1] [2] [3] [4]

Change references:
[1] [2] [3] [4] [5] [6] [7] [8] [9]

codecov Bot commented Dec 30, 2025
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 64.96815% with 55 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.99%. Comparing base (7172f63) to head (43a369c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...t.Core/ServiceLocation/ModernDependencyResolver.cs 57.89% 32 Missing and 8 partials ⚠️
src/Splat.Drawing/PlatformModeDetector.cs 0.00% 7 Missing ⚠️
src/Splat.Drawing/Bitmaps/BitmapLoader.cs 0.00% 3 Missing ⚠️
src/Splat.Logging/MemoizingMRUCache.cs 90.90% 0 Missing and 2 partials ⚠️
src/Splat/ServiceLocation/Locator.cs 77.77% 2 Missing ⚠️
src/Splat.Logging/ConsoleLogger.cs 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1459       +/-   ##
===========================================
+ Coverage   41.58%   72.99%   +31.40%     
===========================================
  Files         147      106       -41     
  Lines        7805     4447     -3358     
  Branches      805      607      -198     
===========================================
  Hits         3246     3246               
+ Misses       4391     1032     -3359     
- Partials      168      169        +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

glennawatson merged commit 7dc2b1f into main Dec 30, 2025
6 checks passed
glennawatson deleted the glennawatson/convert-tunit branch December 30, 2025 10:51

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

github-actions Bot locked as resolved and limited conversation to collaborators Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL