Fix intermittent Raygun test crash caused by unobserved task exceptions - #1510
Fix intermittent Raygun test crash caused by unobserved task exceptions#1510glennawatson merged 5 commits into
Conversation
Sorry, something went wrong.
…st crashes Fire-and-forget tasks from RaygunClient.SendInBackground were being discarded, causing unobserved task exceptions that could surface during process cleanup and crash the test runner.
There was a problem hiding this comment.
Pull request overview
Fixes an intermittent test-runner crash on macOS by ensuring Raygun “fire-and-forget” background send tasks don’t leave faulted Tasks unobserved during shutdown/GC.
Changes:
- Replaced discarded SendInBackground(...) calls with a helper to observe completion.
- Added an internal helper intended to await and suppress background send exceptions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
…tion Replace async void with a synchronous fault-only continuation so exceptions are marked as observed immediately on the completing thread, without relying on thread pool work items during shutdown. Also add XML documentation to Raygun test project.
… comments Add XML documentation to private fields and internal constructor. Fix malformed summary on public constructor. Clarify ambiguous inline comment about the Raygun forum thread with proper context.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
Codecov Report❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
@@ Coverage Diff @@
## main #1510 +/- ##
=======================================
Coverage ? 79.58%
=======================================
Files ? 116
Lines ? 7170
Branches ? 1132
=======================================
Hits ? 5706
Misses ? 1159
Partials ? 305 ☔ View full report in Codecov by Sentry.
|
Sorry, something went wrong.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sorry, something went wrong.
Summary
What changed
RaygunClient.SendInBackground returns a Task that was previously discarded with _ =. If that task faulted, the exception went unobserved and could surface during garbage collection or process cleanup, crashing the host process.
Background send tasks are now wrapped with a synchronous fault-only ContinueWith continuation that marks exceptions as observed immediately on the completing thread, with no thread pool dependency.
Impact
This is a non-breaking internal change. No public API changes. Fire-and-forget sends continue to work exactly as before -- the only difference is that failures no longer risk crashing the host process.