| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
…th all rules Swap the analyzer stack from stylecop.analyzers (1.2.0-beta.556) to StyleSharp.Analyzers 3.3.2 and bring the entire codebase into compliance with the new rule set. This is the bulk of the change: ~300 source files updated for the SST* diagnostics — documentation coverage (SST1600/1601/1602/1654, with summary/element doc settings), whitespace and blank-line rules (SST1505/1507/1518), summary single-line length, and the various wrapping/placement rules — plus the corresponding .editorconfig configuration and the Roslynator overlaps that StyleSharp now owns (RCS0058/0059/0063 disabled). Alongside the analyzer migration, this also folds in a few smaller infrastructure cleanups that the rule churn made convenient to land together: - Compile-included polyfills/helpers: move the shared polyfills and guard helpers to src/Polyfills, compile-included into each assembly with per-TFM Using aliases (BCL types on net8+, polyfills on net4x), and drop InternalsVisibleTo from the production libraries (kept only for test projects that white-box internals). Adds AppLocator.RegisterResolverInitializer so Splat no longer reaches into Splat.Core internals. - Disposables: reference ReactiveUI.Disposables 3.0.0 and delete the internal ActionDisposable/BooleanDisposable/CompositeDisposable copies, rewiring usages to the package types (ActionDisposable.Empty -> EmptyDisposable.Instance, CompositeDisposable -> MultipleDisposable). - Public API tracking: switch from Verify/PublicApiGenerator to the Roslyn PublicApiAnalyzers with per-TFM baselines wired via Directory.Build.props. Verified: full Linux solution builds clean (0 errors/0 warnings) with tests passing, and all Apple TFM builds for Splat.Drawing and Splat.AppCenter (net10/net11 ios, maccatalyst, macos, tvos) pass.
Bring the full solution to a clean `dotnet build -warnaserror` now that SST1600 enforces documentation on private fields and constants. - Add XML doc comments to all private fields/consts flagged by SST1600 across Splat.Core, Splat.Drawing, Splat.Logging and the DI/logging/APM adapters, plus the test projects. - Link the shared LoggerTestConstants into the logging adapter test projects that consume the base test fixtures (fixes CS0234). - Log4Net test: extract the Logs projection into a BuildLogs() method so the interface property no longer copies a collection (S2365). - Serilog test: use the shared LoggerTestConstants.TestMessage (S1192). - BaseDependencyResolverTests: name the repeated contract/count literals as constants (S109/S1192). - Drawing color tests: name magic numbers, rename ARGB* methods to Argb* (S100), and document the Eps tolerance. - Replace the xUnit-era XUnitHelpers with strongly-typed TUnit data sources: SplatColorTests enumerates KnownColor directly and TargetFrameworkExtensionsTests uses a tuple sequence.
Add SonarCloud and CodeQL Advanced analysis workflows using the shared reactiveui/actions-common reusable workflows, matching the Primitives repo setup. SonarCloud excludes the tests and Benchmarks folders from analysis, coverage, copy-paste detection, and test detection. The analysis is skipped automatically when SONAR_TOKEN is not configured (e.g. on forks).
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Sorry, something went wrong.
…ryIoc tests Updated `DryIocDependencyResolver` test cases and assertions to throw `NotSupportedException` instead of `NotImplementedException` where applicable. Adjusted related comments and added `IsDefaultKey` helper method for improved clarity. Incremented relevant package versions in `Directory.Packages.props`.
…ove color conversion logic - Split `FromNative(bool copy)` into separate overloads for better readability. - Introduced `ByteComponentMax` constant for consistent color component normalization. - Adjusted XML doc comments and updated API baselines for all platforms.
- Change `LogLevel.Error` to `LogLevel.Fatal` in test cases to ensure correct log level behavior validation.
- Clarify usage of the `:l` (literal) specifier to avoid added quotes in emitted text.
Codecov Report❌ Patch coverage is 73.26892% with 166 lines in your changes missing coverage. Please review. @@ Coverage Diff @@
## main #1593 +/- ##
==========================================
- Coverage 79.40% 78.95% -0.46%
==========================================
Files 116 124 +8
Lines 7168 7036 -132
Branches 1143 1080 -63
==========================================
- Hits 5692 5555 -137
- Misses 1165 1169 +4
- Partials 311 312 +1 ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
Removed token validation step for SonarCloud analysis.
|
Sorry, something went wrong.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Summary
The headline change is migrating the analyzer stack from StyleCop (stylecop.analyzers 1.2.0-beta.556) to StyleSharp (StyleSharp.Analyzers 3.3.2) and bringing the entire solution — production and test projects — into compliance with the new rule set under -warnaserror. That compliance work is the bulk of this PR.
A few infrastructure cleanups and the CI additions ride along because the rule churn made them convenient to land together.
StyleCop → StyleSharp (the main change)
Test-project compliance (now part of this PR)
CI: SonarCloud + CodeQL
Smaller cleanups landed alongside
Verification