test: raise coverage; remove ancient Xamarin.Forms/UWP runners and Splat.Prism.Forms - #1601
Merged
glennawatson merged 7 commits intoJun 12, 2026
Merged
test: raise coverage; remove ancient Xamarin.Forms/UWP runners and Splat.Prism.Forms#1601glennawatson merged 7 commits into
glennawatson merged 7 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…odules Adds focused coverage tests across previously under-covered areas: - Splat.Logging: SplatLoggerModule, SplatLogManagerModule, DebugLogger, WrappingPrefixLogger, ActionLogger, LogHost, LoggingException - Splat.Microsoft.Extensions.Logging: extensions, log provider, module - Splat.NLog / Log4Net / Exceptionless / Serilog: resolver extensions and IModule registration - Splat.Drawing: BitmapLoader, BitmapLoaderException, mode detectors, drawing initialization, SplatColor - Splat APM: DefaultFeatureUsageTrackingSession, the enable-tracking extensions, FuncFeatureUsageTrackingManager
…Forms Splat.TestRunner.Android (Xamarin.Forms), Splat.TestRunner.Uwp, and the Splat.Prism.Forms (Xamarin.Forms) adapter target frameworks that are no longer supported. Remove the projects and clean up their references: InternalsVisibleTo entries, Splat.slnx, the Prism.Forms package version, and the development docs.
…po bumps The net4*/netstandard targets pin a set of System.* compatibility packages to their 4.x versions; Renovate's .NET monorepo v10 update (e.g. PR #1598) tries to bump them (such as System.Runtime.Serialization.Formatters 4.3.0 -> 10.0.x in the net4 block), which breaks those targets. Add a packageRule that caps System.* packages currently on 4.x below 5.0.0, leaving the modern 10.x entries free to update.
# Conflicts: # src/Directory.Packages.props # src/Splat.Core/Splat.Core.csproj # src/Splat.Prism.Forms/PrismApplication.cs
- Removed Splat.Prism.Forms and related API references for outdated frameworks. - Updated copyright headers across test files to reflect ReactiveUI Association Incorporated. - Cleaned up PublicAPI definitions for removed components.
- Replaced inline literal values with named constants across test files for better readability and maintainability. - Streamlined assertions and variable initializations in various logging, drawing, and resolver tests.
- Simplified disposable logger assertion in `NLogLoggerCoverageTests`. - Added missing spacing for readability in `DebugLoggerCoverageTests`. - Condensed builder initialization logic in `MicrosoftExtensionsLoggingExtensionsCoverageTests`.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1601 +/- ##
==========================================
+ Coverage 78.88% 82.30% +3.42%
==========================================
Files 124 124
Lines 7036 7036
Branches 1080 1080
==========================================
+ Hits 5550 5791 +241
+ Misses 1172 937 -235
+ Partials 314 308 -6 ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
Copy link
Copy Markdown
|
Sorry, something went wrong.
Copy link
Copy Markdown
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two independent changes:
1. Add unit-test coverage
Adds focused tests for previously under-covered code (all green locally):
2. Remove ancient Xamarin.Forms / UWP projects
Not included: Splat.Prism.Maui
A MAUI replacement for Splat.Prism.Forms was investigated but deferred: Prism is now under a proprietary commercial license and its public packages are frozen at 9.0.537 (net8 MAUI only, Aug 2024). There is no net10/11 Prism.Maui on nuget.org to build against, so a supported MAUI adapter isn't currently possible.