FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(applicationinsights): add v3 package by glennawatson · Pull Request #1653 · reactiveui/splat · GitHub

feat(applicationinsights): add v3 package - #1653

Merged
ChrisPulman merged 4 commits into
mainfrom
feat/applicationinsights-v3-package
Jul 24, 2026
Merged

feat(applicationinsights): add v3 package#1653
ChrisPulman merged 4 commits into
mainfrom
feat/applicationinsights-v3-package

Conversation

glennawatson commented Jul 24, 2026
edited
Loading

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?

feat

What is the new behavior?

  • Consumers can choose Splat.ApplicationInsights for the Application Insights v2 SDK or Splat.ApplicationInsightsV3 for the Application Insights v3 SDK.
  • Existing consumers keep native page-view telemetry by staying on Splat.ApplicationInsights; that package remains on the v2 SDK.
  • New v3 consumers reference Splat.ApplicationInsightsV3 and use the v3-prefixed namespace:
using Splat.ApplicationInsightsV3;
  • ApplicationInsightsViewTracking in the v3 package records view navigation as custom events named PageView with the view name in the Name property.
  • ApplicationInsightsFeatureUsageTrackingSession is available in the v3 package for feature start/end events and exception tracking through the existing Splat APM contracts.

What is the current behavior?

  • Splat.ApplicationInsights is the only Application Insights package and is pinned to the v2 SDK.
  • Moving that package directly to v3 would remove native TrackPageView support from consumers because Application Insights v3 removed that API.
  • Related to chore (deps): Update Microsoft.ApplicationInsights to v3 #1505.

What might this PR break?

None. The v3 support is opt-in through a new package, and the existing v2 package remains unchanged.

Checklist

  • I have read the Contribute guide
  • Tests have been added or updated (for bug fixes / features)
  • Docs have been added or updated (for bug fixes / features)
  • Changes target the main branch
  • PR title follows Conventional Commits

Additional information

  • Splat.ApplicationInsightsV3 uses Microsoft.ApplicationInsights 3.1.2.
  • OpenTelemetry.Api is pinned to 1.17.0 to avoid vulnerable transitive versions from the v3 SDK dependency graph.
  • The v3 public API entries are in shipped baselines for all target frameworks.
  • Verified locally with dotnet build Splat.slnx -c Release, dotnet test --solution Splat.slnx -c Release, and the v3 test project after moving the new APIs to shipped.

- Add Splat.ApplicationInsightsV3 as an opt-in package for Application Insights v3 consumers.

- Keep Splat.ApplicationInsights on the v2 SDK so native PageView telemetry remains available.

- Document that v3 view tracking uses custom PageView events because the v3 SDK removed TrackPageView.
- Move the new Splat.ApplicationInsightsV3 API baseline entries into shipped files for every target framework.

codecov Bot commented Jul 24, 2026
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.98%. Comparing base (250c692) to head (9f6f8ff).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1653      +/-   ##
==========================================
+ Coverage   96.95%   96.98%   +0.02%     
==========================================
  Files         124      128       +4     
  Lines        6710     6760      +50     
  Branches     1008     1009       +1     
==========================================
+ Hits         6506     6556      +50     
  Misses        111      111              
  Partials       93       93              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- Extract Application Insights v3 telemetry shapes into an internal factory used by view and feature tracking.

- Add direct tests for PageView, feature event, child feature, and exception telemetry metadata.
- Move Application Insights v3 feature session state and send operations into an internal core type.

- Keep the public session adapter focused on the Splat APM contract to avoid cloning the v2 implementation shape.

Copy link
Copy Markdown

ChrisPulman merged commit b31daca into main Jul 24, 2026
13 checks passed
ChrisPulman deleted the feat/applicationinsights-v3-package branch July 24, 2026 07:44

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

github-actions Bot locked as resolved and limited conversation to collaborators Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL