FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: adopt PublicApiSharp public API baselines and LF line endings by glennawatson · Pull Request #1667 · reactiveui/splat · GitHub

build: adopt PublicApiSharp public API baselines and LF line endings - #1667

Merged
glennawatson merged 3 commits into
mainfrom
build/publicapi-sharp-baselines
Aug 1, 2026
Merged

build: adopt PublicApiSharp public API baselines and LF line endings#1667
glennawatson merged 3 commits into
mainfrom
build/publicapi-sharp-baselines

Conversation

glennawatson commented Aug 1, 2026
edited
Loading

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?

  • Build change: how the public API surface is tracked, plus line-ending normalisation.

What is the new behavior?

  • Each project keeps a single PublicAPI.txt per target framework, written as ordinary C#, so an API diff reads like the API change itself and is accepted in the same commit that makes it.
  • Line endings are LF in the repository and in every working tree, on every platform.

What is the current behavior?

  • The public API lives in a Shipped/Unshipped text-file pair per target framework, with a manual promotion step before release.
  • Line endings are normalised only in the object database, so a Windows checkout still gets CRLF in the working tree.

What might this PR break?

  • None. The public surface itself is unchanged; the baselines were regenerated from the same compilations.

Checklist

  • I have read the Contribute guide
  • Tests have been added or updated (for bug fixes / features)
  • Docs have been added or updated (for bug fixes / features)
  • Changes target the main branch
  • PR title follows Conventional Commits

Additional information

  • Verified with a full dotnet build Splat.slnx -c Release on Linux and on Windows - the Windows run covers every target framework, including the Apple and .NET Framework ones - with 0 warnings and 0 errors on both.

- Replace Microsoft.CodeAnalysis.PublicApiAnalyzers with PublicApiSharp.Analyzers.
- Collapse the per-TFM Shipped/Unshipped file pairs into one PublicAPI.txt.
- Baselines are now ordinary C#, so a diff reads like the API change itself.
- Drop the manual AdditionalFiles wiring; the package resolves the per-TFM path.
- Swap the RS0016/RS0017 severities for PAS0004, which reports untracked TFMs.
- Check out LF in every working tree, not just in the object database.
- Set end_of_line for editors, and mark the tracked bitmap fixture binary.
…-baselines

# Conflicts:
#	src/Directory.Packages.props

sonarqubecloud Bot commented Aug 1, 2026

Copy link
Copy Markdown

codecov Bot commented Aug 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.98%. Comparing base (710b7fa) to head (aea1937).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1667   +/-   ##
=======================================
  Coverage   96.98%   96.98%           
=======================================
  Files         128      128           
  Lines        6760     6760           
  Branches     1009     1009           
=======================================
  Hits         6556     6556           
  Misses        111      111           
  Partials       93       93           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

glennawatson merged commit 5f8bd5b into main Aug 1, 2026
13 checks passed
glennawatson deleted the build/publicapi-sharp-baselines branch August 1, 2026 02:04

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

github-actions Bot locked as resolved and limited conversation to collaborators Aug 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL