fix(simpleinjector): key registrations by contract and stop dropping Register - #1670
Merged
ChrisPulman merged 1 commit intoAug 2, 2026
Merged
fix(simpleinjector): key registrations by contract and stop dropping Register#1670ChrisPulman merged 1 commit into
ChrisPulman merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…Register - Hold contract registrations in a table beside the container, since Simple Injector has no keyed registrations. A contract registration now only answers a lookup for the same contract, never shadows the contract-less registration, and two contracts for one service type stay distinct. - Carry the initializer's contract registrations across to the resolver when the container is wired up. - Make the resolver's Register append into the container instead of silently doing nothing, so a registration made after the locator is wired up (a logger, for instance) takes effect - or fails loudly with Simple Injector's own exception once the container has been locked by a resolution. - Report the collection registrations this resolver made from HasRegistration; Simple Injector does not surface them until the container is locked. - Return null/empty from the initializer's non-generic lookups when a type is unregistered instead of throwing. Fixes #240
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1670 +/- ##
==========================================
+ Coverage 97.60% 97.65% +0.05%
==========================================
Files 127 128 +1
Lines 6757 6911 +154
Branches 1025 1071 +46
==========================================
+ Hits 6595 6749 +154
Misses 91 91
Partials 71 71 ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
Copy link
Copy Markdown
|
Sorry, something went wrong.
ChrisPulman
approved these changes
Aug 2, 2026
Copy link
Copy Markdown
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix.
What is the new behavior?
What is the current behavior?
What might this PR break?
Checklist
Additional information
Simple Injector has no keyed registrations, so contracts are held in a table beside the container and are deliberately not injectable by the container itself; this is documented in the class remarks and the package readme. The container-locking behaviour the design depends on was verified directly rather than assumed. 412 tests pass across the seven target frameworks.