Update PHPUnit configuration schema for PHPUnit 9.3 - #43
Merged
WyriHaximus merged 1 commit intoAug 28, 2020
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
jsor
approved these changes
Aug 28, 2020
clue
approved these changes
Aug 28, 2020
clue
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
@SimonFrings Thanks for the update, changes LGTM! 
Sorry, something went wrong.
WyriHaximus
approved these changes
Aug 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHPUnit 9.3 released a new schema for the phpunit.xml configuration file. I had to migrate the file to the new format in order to avoid the warning. PHPUnit Versions older than 9.3 have to use the phpunit.xml.legacy configuration file, because the new format is unknown for them.
For further details concerning this pull request look into graphp/graphviz#46.
This pull request builds on top of reactphp/cache#41.
It's also possible to run this code with PHP 8 🎉
$ docker run -it --rm -v `pwd`:/data --workdir=/data php:8.0.0beta1-cli php vendor/bin/phpunit PHPUnit 9.3.8 by Sebastian Bergmann and contributors. ...................... 22 / 22 (100%) Time: 00:00.010, Memory: 6.00 MB OK (22 tests, 41 assertions)