Test on PHP 8.2 - #52
Merged
clue merged 1 commit intoAug 27, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
WyriHaximus
force-pushed
the
1.x-test-on-php.8.2
branch
from
9c8d31f to
858eb85
Compare
August 23, 2022 06:39
With PHP 8.2 coming out later this year, we should be reading for it's release to ensure all out code works on it. Refs: reactphp/event-loop#258
WyriHaximus
force-pushed
the
1.x-test-on-php.8.2
branch
from
858eb85 to
19886b1
Compare
August 23, 2022 07:09
WyriHaximus
marked this pull request as ready for review
August 23, 2022 07:56
clue
approved these changes
Aug 27, 2022
clue
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
@WyriHaximus Thanks for the update, changes LGTM! 
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With PHP 8.2 coming out later this year, we should be reading for it's release to ensure all out code works on it.
Refs: reactphp/event-loop#258