FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Link to our official Gitter chat room by clue · Pull Request #432 · reactphp/reactphp · GitHub

/ reactphp Public

Link to our official Gitter chat room - #432

Merged
jsor merged 1 commit into
reactphp:masterfrom
clue-labs:gitter
Nov 17, 2019
ConversationCommits (1)ChecksFiles changed
Merged

Link to our official Gitter chat room#432
jsor merged 1 commit into
reactphp:masterfrom
clue-labs:gitter

Conversation

clue commented Nov 17, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

We've deprecated our old IRC channel and now use a Gitter chat room
instead: https://gitter.im/reactphp/reactphp

Refs #429
Refs reactphp/website#50

Link to our official Gitter chat room
9a1d2e9 
We've deprecated our old IRC channel and now use a Gitter chat room
instead: https://gitter.im/reactphp/reactphp
clue added this to the v1.1.0 milestone Nov 17, 2019
WyriHaximus reviewed Nov 17, 2019
View reviewed changes
Comment thread composer.json
"support": {
"issues": "https://github.com/reactphp/react/issues",
"irc": "irc://irc.freenode.org/reactphp"
"chat": "https://gitter.im/reactphp/reactphp"

WyriHaximus Nov 17, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Should we add this to all our packages?

clue Nov 17, 2019

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm undecided, but I can see some use for this 🤷‍♂️

WyriHaximus Nov 17, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It shows up on the packagist page for each package so might not be a bad idea 😄

clue Nov 17, 2019 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@WyriHaximus Fair point! My vote would be to postpone this discussion until we see we're happy with adoption of the new chat room and then discuss this in a separate ticket in a few weeks and not hold this one back

WyriHaximus Nov 17, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@clue of course, just thinking out loud :)

clue mentioned this pull request Nov 17, 2019
Merged
clue requested review from WyriHaximus and jsor November 17, 2019 20:10
jsor merged commit 77d70f7 into reactphp:master Nov 17, 2019
clue deleted the gitter branch November 18, 2019 09:01
clue mentioned this pull request Nov 18, 2019
Merged
clue mentioned this pull request Sep 10, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jsor jsor approved these changes
WyriHaximus WyriHaximus approved these changes

Assignees

No one assigned

Labels

easy pick maintenance

Projects

None yet

Milestone

v1.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL