Forward compatibility with upcoming Promise v3 - #464
Merged
WyriHaximus merged 2 commits intoOct 4, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Updated to resolve merge conflict now that #462 is in. This now only depends on the next HTTP release now that reactphp/http#460 has been merged. I'll make sure to update this PR once we make progress. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Updated now that HTTP v1.8.0 has been released, this is now ready for review |
Sorry, something went wrong.
SimonFrings
approved these changes
Sep 29, 2022
WyriHaximus
approved these changes
Oct 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of
Also builds on top of #462 to fix the test suite for Async v4 first