FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add issue template for better orientation by SimonFrings · Pull Request #466 · reactphp/reactphp · GitHub

/ reactphp Public

Add issue template for better orientation - #466

Merged
WyriHaximus merged 1 commit into
reactphp:1.xfrom
SimonFrings:issue_template
Oct 4, 2022
ConversationCommits (1)ChecksFiles changed
Merged

Add issue template for better orientation#466
WyriHaximus merged 1 commit into
reactphp:1.xfrom
SimonFrings:issue_template

Conversation

SimonFrings commented Sep 6, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

This pull request adds issue templates to this project.

With GitHub Discussions now activated on an organizational level (as discussed in #460), it makes sense to add issue templates to each ReactPHP repository to show users where they have to open up specific tickets:

  • New feature ideas and questions belong in ReactPHP discussions. GitHub discussions are more long-lived than issues, thus enabling better visibility for users.
  • We'll continue to use issues for bug reports. These bugs will be fixed at some point and then belong in closed issues. Additionally I won't add a bug template to reactphp/reactphp. IMO it makes no sense to report a bug in this repository. All bugs should be reported inside the related repo (http, socket, dns, etc.).
  • Security issues should be reported to us via email. It is important not to make security-related issues public before they have been fixed!

I will file pull requests to add issue templates for each ReactPHP repository. Repos like https://github.com/reactphp/branding or https://github.com/reactphp/.github won't receive them (makes no sense).

nhedger commented Sep 8, 2022

Copy link
Copy Markdown
Contributor

I believe it's possible to create default issue templates at the organization level.

This should save you from having to open PR on all repositories.

SimonFrings commented Sep 8, 2022

Copy link
Copy Markdown
Member Author

@nhedger You're totally right, the only thing I'd have to do is to add the ISSUE_TEMPLATE folder to the .github folder inside reactphp/.github and it's done.

The downside is that EVERY project inside the ReactPHP organisation gets the same issue template. This may make sense for most projects (like dns, http, etc.) but not for something like reactphp/branding or reactphp/reactphp. I would instantly do this if GitHub had some kind of functionality to exclude specific repositories, but I didn't find anything similar.

In conclusion: I am willing to take the slightly longer road and do it for every repository individually (which means only to copy-paste at some point 😄). Just feels right ^^

SimonFrings commented Sep 12, 2022

Copy link
Copy Markdown
Member Author

@clue, @WyriHaximus I had to rebase my chnages to match #462, now all tests are green and this is ready for review.

WyriHaximus approved these changes Sep 14, 2022
View reviewed changes

WyriHaximus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

👍

WyriHaximus requested a review from clue September 14, 2022 20:59
nhedger reviewed Sep 14, 2022
View reviewed changes
Comment thread .github/ISSUE_TEMPLATE/config.yml Outdated
clue reviewed Sep 22, 2022
View reviewed changes
Comment thread .github/ISSUE_TEMPLATE/config.yml
clue approved these changes Sep 30, 2022
View reviewed changes

clue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@SimonFrings Thank you for the update, changes LGTM!

clue requested a review from WyriHaximus September 30, 2022 12:02
WyriHaximus merged commit 8ba9ccd into reactphp:1.x Oct 4, 2022
SimonFrings mentioned this pull request Oct 12, 2022
Merged
This was referenced Oct 24, 2022
Merged
Merged
Merged
Merged
Merged
This was referenced Nov 17, 2022
Merged
Merged
Merged
Merged
Merged
SimonFrings mentioned this pull request Jan 9, 2023
Merged
clue added this to the v1.4.0 milestone Mar 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

WyriHaximus WyriHaximus approved these changes
clue clue approved these changes
+1 more reviewer
nhedger nhedger left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

maintenance

Projects

None yet

Milestone

v1.4.0

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL